[Openvpn-devel] async plugin-auth-pam

2020-06-09 Thread Gert Doering
Hi, I ran into a problem at a customer installation recently, where plugin-auth-pam was blocking for some extended time (~30 seconds?) due to pam_radius not receiving answers due to problems in the backend. Now, maybe I should use radiusplugin in the first place, but since the pam_radius setup

[Openvpn-devel] [PATCH applied] Re: Simplify pool size handling, fix possible array overrun on pool reading.

2020-06-09 Thread Gert Doering
Patch has been applied to the master branch. I have amended most whitespace as requested, and removed the "pool-> size = 0" initialization (not needed, indeed). I have left the brackets on the pool size calculation as they were - uncrustify says "that is also ok", and I find visibly grouping the

[Openvpn-devel] [PATCH applied] Re: ipv6-pool: get rid of size constraint

2020-06-09 Thread Gert Doering
Acked-by: Gert Doering Stared-at-code and tested on the t_server machine. And crashed. But that was not actually *this* patch's fault, but 6a8cd033b18's (fixed). This code does what it says on the lid - loosen up the "/112 is the minimum size" restriction on IPv6 pools, up to a /124 (which we

Re: [Openvpn-devel] [PATCH] Simplify pool size handling, fix possible array overrun on pool reading.

2020-06-09 Thread Antonio Quartulli
Hi, On 09/06/2020 10:02, Gert Doering wrote: > Remove separate ipv4.size and ipv6.size in the pool structure, return > to a single pool_size, which is also the allocated array size. > > All calls to ifconfig_pool_size() change to "pool->size" now. > > pool->size is set to the size of the active

[Openvpn-devel] [PATCH] Simplify pool size handling, fix possible array overrun on pool reading.

2020-06-09 Thread Gert Doering
Remove separate ipv4.size and ipv6.size in the pool structure, return to a single pool_size, which is also the allocated array size. All calls to ifconfig_pool_size() change to "pool->size" now. pool->size is set to the size of the active pool, or if both IPv4 and IPv6 are in use, to the smaller