Hi,
On Mon, Mar 30, 2020 at 8:59 AM Paolo Cerrito wrote:
> 1) so remote was set to the maxlenght of ipv6 address defined into
> arpa/inet.h + 1 for string terminator
>
> 2) I refactored the call to get_env to take first ipv6 address, then
>only if it is NULL, i make a call for ipv4
> ---
>
Hi Lev,
I'm struggling with family duties now that schools are closed. This makes it
hard to find any time for computers.
Nevertheless, should find_adapters() fail for some reason, it is not critical
to bail out of FindSystemInfo() custom action.
The find_adapters() itself already displays a r
From: Selva Nair
This helps the next patch. No functionality changes, only
refactoring.
Signed-off-by: Selva Nair
---
No changes from v1
src/openvpn/misc.c | 54 ++
1 file changed, 34 insertions(+), 20 deletions(-)
diff --git a/src/openvpn/
From: Selva Nair
When only username is found in the file, redirect the auth-user-pass
query to the management if management-query-passwords is enabled.
Otherwise the user is prompted on console, if available, as before.
This changes the behaviour for those who run from the command line,
with --m
On Mon, Mar 30, 2020 at 12:30 PM Selva Nair wrote:
> That is, if management-query-passwords is enabled and auth file is
> missing password, query the management, not on console irrespective
> of other options and OS. If that's acceptable, I'll submit a v2.
That's fine with me (and Tunnelblick),
Hi,
On Mon, Mar 30, 2020 at 12:29:44PM -0400, Selva Nair wrote:
> Personally I would prefer to enable this code for all platforms although
> its a minor regression.
>
> That is, if management-query-passwords is enabled and auth file is
> missing password, query the management, not on console irre
Hi,
On Mon, Mar 30, 2020 at 12:11 PM Jonathan K. Bullard
wrote:
> Hi,
>
> On Mon, Mar 30, 2020 at 11:12 AM Selva Nair wrote:
> > Jonathan K. Bullard wrote:
> > >
> > > If the OS X command line user was using --management-query-passwords
> > > (as Tunnelblick does), they wouldn't see the passwo
Hi,
On Mon, Mar 30, 2020 at 11:12 AM Selva Nair wrote:
> Jonathan K. Bullard wrote:
> >
> > If the OS X command line user was using --management-query-passwords
> > (as Tunnelblick does), they wouldn't see the password prompt on
> > /dev/tty, would they?
>
> In case of auth-file missing password
Hi,
On Mon, Mar 30, 2020 at 2:07 AM Gert Doering wrote:
>
> Hi,
>
> On Sun, Mar 29, 2020 at 07:58:15PM -0400, Selva Nair wrote:
> > Yes, that's right. However, that logic wont be proper on OS-X, would it?
> > Command line users who use --log can still see password
> > prompt on /dev/tty. We'll be
1) so remote was set to the maxlenght of ipv6 address defined into
arpa/inet.h + 1 for string terminator
2) I refactored the call to get_env to take first ipv6 address, then
only if it is NULL, i make a call for ipv4
---
src/plugins/auth-pam/auth-pam.c | 8 +---
1 file changed, 5 insertio
From: Paolo Cerrito
1) changed again remote lenght, we have to consider only the lenght op
ipv6 address into form :::::ddd.ddd.ddd.ddd not
the mask, so we have max lenght of 45 plus terminator.
2) refactored calls to get_env, now we make one call to take ipv6
address, t
Hi,
On 30/03/2020 07:55, Gert Doering wrote:
>> Not sure now what would be the best approach forward. Picking the commit
>> contents from a rebased icsopenvpn branch would be one way (I can provide
>> commitish references I reviewed, if needed). Another approach is for Arne to
>> resend rebased p
12 matches
Mail list logo
