Re: [Openvpn-devel] OpenVPN 2.4.8 released

2019-11-06 Thread d tbsky
> It would be interesting too what error message there is in setupapi.dev.log: > I found a win7 vm with openvpn 2.4.6. try to upgrade to 2.4.8 and get the same result. setupapi.dev.log attached. there are some international characters but I think they are not important. I snapshot the vm before u

Re: [Openvpn-devel] [PATCH applied] Re: maddr: export VLAN ID from client context to maddr object

2019-11-06 Thread Gert Doering
Hi, On Wed, Nov 06, 2019 at 10:11:58PM +0100, Gert Doering wrote: > As a side note: it seems that whoever did the IPv6 payload patches was > a bit sloppy (it was me, so I am allowed to say that). MAC learning is > only done on IPv4 and ARP packets, but not on IPv6 packets - so I expect > "ipv6

[Openvpn-devel] [PATCH applied] Re: maddr: export VLAN ID from client context to maddr object

2019-11-06 Thread Gert Doering
Acked-by: Gert Doering Stared at the code, ran client side tests, full set of server side tests, and compiled (+client tested) on FreeBSD 7.4 to give the "anonymous union explosion" bits a good checking :-) (it does not explode anymore, thanks for fixing that). Similar to 2/9, this patch does

[Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-06 Thread Gert Doering
Acked-by: Gert Doering Stared at the code (twice now), run t_client and t_server tests. This patch does not really *do* much yet, but it lays the groundwork for future work - the "broadcast only to clients in the same vlan" part is there, but it's always called with "0" (= all clients). As far

[Openvpn-devel] [PATCH applied] Re: Fix broken fragmentation logic when using NCP

2019-11-06 Thread Gert Doering
Acked-by: Gert Doering Thanks for clarifying what the actual problem is, so we have it nicely in the logs. I have diff'ed this patch vs. d22ba6b2c551f, and the only difference is related to "use_iv" which got kicked out from master. So I'm mostly relying on the ACks from Arne and Steffan and no

Re: [Openvpn-devel] OpenVPN 2.4.8 released

2019-11-06 Thread samuli
Hi, Il Mercoledì 6 novembre 2019, d tbsky scrive: > after reading the thread, I think now it's safe to upgrae my windows 7 > from openvpn 2.4.7 to 2.4.8. so I download the installer and click > it. > > the installer complains about can not install tap drivers and I click > ok to let it go. when

Re: [Openvpn-devel] [PATCH] tun/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-06 Thread Gert Doering
Hi, On Mon, Nov 04, 2019 at 05:10:12AM +0800, Tom Yan wrote: > So in master, when net_addr_v4_add is called in tun.c, which > net_addr_v4_add (networking_iproute2.c or networking_sitnl.c) is > actually used depends on how openvpn is built, right? Right. It's either "default options" (-> sitnl.c)