Re: [Openvpn-devel] [PATCH] Fix compilation with LibreSSL

Hi Arne, Thanks for the reply. Please see my comments and a clarifying question below. On 24/02/2019 03:28, Arne Schwabe wrote: > And I > am getting quite fed up with way that LibreSSL does API compatiblity. It > claims to support OpenSSL 2.0.0 API when it clearly doesn't. Sorry, but LibreSSL of

[Openvpn-devel] [PATCH] Add developer notes URL for openvpnmsica.dll

This patch follows Gert's recommendations from [openvpn-devel]. Signed-off-by: Simon Rozman Message-ID: <201901181957.x0ijvlq2003...@chekov.greenie.muc.de> --- src/openvpnmsica/dllmain.c | 1 + src/openvpnmsica/msica_op.c | 1 + src/openvpnmsica/msica_op.h | 1 + src/openvpnmsica/ms

[Openvpn-devel] [PATCH] Refactor OpenVPNService state detection code

The code was standardized to avoid "E1072: a declaration cannot have a label" warning of Visual Studio 2017 IntelliSense. Furthermore, a comment explaining what `dwStartType <= SERVICE_AUTO_START` condition is about. This patch follows Gert's recommendations from [openvpn-devel]. Signed-off-by:

[Openvpn-devel] [PATCH] Limit tapctl.exe and openvpnmsica.dll to TAP-Windows6 adapters only

Note: Hardware ID check is used selectively. When naming the adapter, we still need to check all existing adapters to prevent duplicate names. When listing or removing adapters by name, the operation is limited to TUN-Windows6 adapters only. This patch follows Gert's recommendations from [openvpn-

[Openvpn-devel] [PATCH] Add user manual and developer notes URL for tapctl.exe

This patch follows Gert's recommendations from [openvpn-devel]. Signed-off-by: Simon Rozman Message-ID: <20190117155829.ga92...@greenie.muc.de> --- src/tapctl/basic.h | 1 + src/tapctl/error.c | 1 + src/tapctl/error.h | 1 + src/tapctl/main.c | 1 + src/tapctl/tap.c | 1 + src/tapctl/tap.h

[Openvpn-devel] [PATCH] Add NULL checks

Extra NULL checks were added after malloc() calls to display out-of- memory error and try to exit gracefully. Function msica_op_create_*() now return NULL in out-of-memory condition too. Since their output is directly used in msica_op_seq_add_head() and msica_op_seq_add_tail() functions, later wer

[Openvpn-devel] [PATCH] Disambiguate thread local storage references from TLS

Since OpenVPN is security software, "TLS" usually stands for Transport Layer Security. Furthermore, repetitive copy&paste code was refactored using a macro. This patch follows Gert's recommendations from [openvpn-devel]. Signed-off-by: Simon Rozman Message-ID: <20190117155829.ga92...@greenie.mu