Re: [Openvpn-devel] [PATCH 3/5] Define _WIN32_WINNT=_WIN32_WINNT_VISTA in MSVC

2018-11-08 Thread Jon Kunkee via Openvpn-devel
LGTM, Samuli. -Original Message- From: Simon Rozman Sent: Tuesday, October 16, 2018 3:26 AM To: openvpn-devel@lists.sourceforge.net Subject: [Openvpn-devel] [PATCH 3/5] Define _WIN32_WINNT=_WIN32_WINNT_VISTA in MSVC This makes MSVC and MinGW build environments more alike. --- src/open

Re: [Openvpn-devel] [PATCH 2/5] Prevent __stdcall name mangling of MSVC

2018-11-08 Thread Jon Kunkee via Openvpn-devel
Hi Simon, This approach keeps 'goes in DLL' next to the function itself, which I like. If you're interested, another possible approach here is to use .DEF files with MSVC, which can also do symbol aliasing: https://docs.microsoft.com/en-us/cpp/build/exporting-from-a-dll-using-def-files I would

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-08 Thread Jon Kunkee via Openvpn-devel
Hi Simon, This is painful to read, and I bet it was even more painful to write. I am sorry it came to this, though it does look like it should(TM) work. >From what I gather, the OS version should be checked in the CustomAction's MSI execution conditions instead of in the CustomAction itself. T

Re: [Openvpn-devel] [PATCH 5/5] Detect TAP interfaces with root-enumerated hardware ID

2018-11-08 Thread Jon Kunkee via Openvpn-devel
Samuli, LGTM. -Original Message- From: Simon Rozman Sent: Tuesday, October 16, 2018 3:26 AM To: openvpn-devel@lists.sourceforge.net Subject: [Openvpn-devel] [PATCH 5/5] Detect TAP interfaces with root-enumerated hardware ID This patch extends the TAP interface enumerating to detect the

Re: [Openvpn-devel] [PATCH 1/5] Set output name to libopenvpnmsica.dll in MSVC builds too

2018-11-08 Thread Jon Kunkee via Openvpn-devel
This looks pretty straightforward to me. -Original Message- From: Simon Rozman Sent: Tuesday, October 16, 2018 3:26 AM To: openvpn-devel@lists.sourceforge.net Subject: [Openvpn-devel] [PATCH 1/5] Set output name to libopenvpnmsica.dll in MSVC builds too On MinGW builds, the Libtool pro

Re: [Openvpn-devel] developers documentation

2018-11-08 Thread Arne Schwabe
Am 08.11.18 um 13:31 schrieb milovan bjelogrlic: > hi OpenVPN developers, > > Could you please provide me with information if there is place with > documentation which contains API reference, code implementation > documentation and any othed kinf of(good :)) documentation. I am > interested in ope

[Openvpn-devel] developers documentation

2018-11-08 Thread milovan bjelogrlic
hi OpenVPN developers, Could you please provide me with information if there is place with documentation which contains API reference, code implementation documentation and any othed kinf of(good :)) documentation. I am interested in openvpn3 library development. As I could see there is no such de