Re: [Openvpn-devel] [PATCH] Add support for OpenSSL TLS 1.3 when using management-external-key

2018-10-16 Thread Selva Nair
Hi, Not a review, but some thoughts: On Sun, Oct 7, 2018 at 5:59 PM Arne Schwabe wrote: > > For TLS 1.0 to 1.2 OpenSSL calls us and requires a PKCS1 padded > response, for TLS 1.3 it requires to an unpadded response. Since we > can PCKS1 pad an unpadded response, we prefer to always query for >

Re: [Openvpn-devel] [PATCH] Windows: Set interface IPv6 prefix length when configuring address

2018-10-16 Thread Selva Nair
Hi, Going through patchworks noticed this. Thankfully this never got committed so here goes a retraction. On Sun, Jan 21, 2018 at 1:45 PM Selva Nair wrote: > Hi, > > I'm on a reviewing spree (doing my penance), so here goes.. > > Thanks for the patch > > On Tue, Jan 9, 2018 at 2:16 AM, Eyal Bi

Re: [Openvpn-devel] [PATCH applied] Refuse mbed TLS external key with non RSA certificates

2018-10-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Fixed coding style detail spotted by Steffan on-the-fly during commit. Your patch has been applied to the master branch commit b3c24842a807014c1663eed6f79e888d73182205 Author: Arne Schwabe Date: Mon Oct 8 23:41:23 2018 +0200 Refuse mbed TLS

Re: [Openvpn-devel] [PATCH applied] ifconfig-ipv6(-push): allow using hostnames

2018-10-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the following branches commit 2b15c11716e0d04a090585450e8f8f65405d0192 (master) commit 1e3672c95e648286e9242c0faf70a79f11e192cb (release/2.4) Author: Antonio Quartulli Date: Sun Dec 3 12:14:26 2017 +0800 ifco

Re: [Openvpn-devel] [PATCH applied] buffer_list_aggregate_separator(): simplify code

2018-10-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Commit message type fixed during commit. Your patch has been applied to the following branches commit e883c66b9da390f56ef4a596c9eb6b237a185a50 (master) commit be47e4292459aabdf89e53d9f5747b113fc2cd5d (release/2.4) Author: Steffan Karger Date: F

Re: [Openvpn-devel] [PATCH applied] buffer_list: add functions documentation

2018-10-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Typo spotted by Steffan got fixed during commit. Your patch has been applied to the following branches commit e72b2f2ce062c76c6ab658b7ae961f8b81cba307 (master) commit 61ef9057cda9e1a52786a16e01cd9368fec8a74e (release/2.4) Author: Antonio Quartull

[Openvpn-devel] [PATCH 1/5] Set output name to libopenvpnmsica.dll in MSVC builds too

2018-10-16 Thread Simon Rozman
On MinGW builds, the Libtool produces libopenvpnmsica.dll. The MSVC properties were updated to match this. --- src/openvpnmsica/openvpnmsica.props| 4 +++- src/openvpnmsica/openvpnmsica_resources.rc | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/openvpnmsica/ope

[Openvpn-devel] [PATCH 3/5] Define _WIN32_WINNT=_WIN32_WINNT_VISTA in MSVC

2018-10-16 Thread Simon Rozman
This makes MSVC and MinGW build environments more alike. --- src/openvpnmsica/openvpnmsica.props | 1 + src/tapctl/tapctl.props | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpnmsica/openvpnmsica.props b/src/openvpnmsica/openvpnmsica.props index fa40829

[Openvpn-devel] [PATCH 2/5] Prevent __stdcall name mangling of MSVC

2018-10-16 Thread Simon Rozman
Using `extern "C" __declspec(dllexport) __stdcall`, Win32 MSVC compiler exports the functions are as `_name@N`. Exporting functions using `/EXPORT` linker flag allows us to specify exact function name. Note: The 64-bit MSVC compiler does not exhibit `__stdcall` name- mangling. --- src/openvpnmsic

[Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-10-16 Thread Simon Rozman
This patch introduces a `FindSystemInfo()` MSI custom action to reliably detect Windows 10. The MSI built-in properties for Windows version detection depend on bootstrapper's manifest. We could provide our own Windows 10 compatible EXE bootstrapper, but that would cover the Windows 10 detection in

[Openvpn-devel] [PATCH 5/5] Detect TAP interfaces with root-enumerated hardware ID

2018-10-16 Thread Simon Rozman
This patch extends the TAP interface enumerating to detect the TAP interfaces registered using "root\tap0901" hardware ID. Before, only TAP interfaces with legacy "tap0901" HWID were detected by openvpn.exe. The openvpnmsica.dll and tapctl.exe install TAP interfaces using root- enumerated HWIDs, a