We have plenty real unit test that can be used as examples, so the
example tests are no longer needed. Let's get rid of them.
Signed-off-by: Steffan Karger
---
tests/unit_tests/Makefile.am | 2 +-
tests/unit_tests/example_test/Makefile.am | 13
tests/unit_tests/example_tes
Commit 674b166 ("Fix build warnings related to get_random()") broke the
unit tests for mbedtls, because was now included via
platform.c -> crypto.h -> crypto_backend.h, but the crypto cflags were
not included for that unit tests.
Since we got rid of --disable-crypto, we can now fix this by simply
Hi
On Tue, Oct 9, 2018 at 5:14 PM Selva Nair wrote:
>
>
> In fact the issue here is not the unary minus, but the unsigned to signed
> conversion. So when there is no scope for overflow all is good. If there is
> overflow, unsigned->signed conversion is ill-defined -- cast doesn't fix
> it. In fa
Hi,
More noise: a typo alert below:
On Tue, Oct 9, 2018 at 5:14 PM Selva Nair wrote:
> Hi
>
> On Tue, Oct 9, 2018 at 4:39 PM Steffan Karger wrote:
>
>> Hi,
>>
>> On 08-10-18 18:09, Lev Stipakov wrote:
>> > From: Lev Stipakov
>> >
>> > In Visual Studio when unary minus is applied to unsigned,
Hi
On Tue, Oct 9, 2018 at 4:39 PM Steffan Karger wrote:
> Hi,
>
> On 08-10-18 18:09, Lev Stipakov wrote:
> > From: Lev Stipakov
> >
> > In Visual Studio when unary minus is applied to unsigned,
> > result is still unsigned. This means that when we use result
> > as function formal parameter, we
Hi,
On 08-10-18 23:41, Arne Schwabe wrote:
> The current API that we use (mbedtls_pk_setup_rsa_alt) only allows
> using RSA keys with the external API. Using an EC, mbed TLS and external
> key in OpenVPN will fail very late with a rather obscure error message.
>
> Instead fail early and provide a
As Antonio pointed out, "8-bit block cipher" is a bit funny. So teach
print_cipher() to print such cipher as "stream cipher".
Because I didn't want to write the same code twice, I decided to merge the
two print_cipher() implementations into one shared function. That should
make it easier to keep b
Hi,
On 08-10-18 18:09, Lev Stipakov wrote:
> From: Lev Stipakov
>
> In Visual Studio when unary minus is applied to unsigned,
> result is still unsigned. This means that when we use result
> as function formal parameter, we pass incorrect value.
>
> Fix by adding explicit cast to signed type.
>
On 08/10/18 21:47, Gert Doering wrote:
> Acked-by: Gert Doering
>
> For the reasons given - it's code that has not been activated anywhere
> in the last 5+ years, there is no way to turn it on by configure, and
> it's likely not working right on half the platforms. And less #ifdef!
And to add a
Hi,
On 09-10-18 20:43, Gert Doering wrote:
> (copying in openvpn-devel, as this is something Steffan will want to
> see...)
>
> On Tue, Oct 09, 2018 at 06:41:30PM +0300, Alex K wrote:
>> Adding some more lines (verbosity 3):
>>
>> Tue Oct 9 15:38:17 2018 UDP link remote: [AF_INET]:1195
>> Tue Oc
Hi,
(copying in openvpn-devel, as this is something Steffan will want to
see...)
On Tue, Oct 09, 2018 at 06:41:30PM +0300, Alex K wrote:
> Adding some more lines (verbosity 3):
>
> Tue Oct 9 15:38:17 2018 UDP link remote: [AF_INET]:1195
> Tue Oct 9 15:38:17 2018 TLS: Initial packet from [AF_IN
Am 09.10.18 um 14:34 schrieb Jan Just Keijser:
> Hi Ralf,
>
> On 09/10/18 13:35, Ralf Hildebrandt wrote:
>> Currently we're suppling our user with a charite.ovpn File containing:
>>
>> ...
>> compress lzo
>> ...
>>
>> In some cases, we're overriding this on the server side by using:
>>
>> if (defi
Hi Ralf,
On 09/10/18 13:35, Ralf Hildebrandt wrote:
Currently we're suppling our user with a charite.ovpn File containing:
...
compress lzo
...
In some cases, we're overriding this on the server side by using:
if (defined $ENV{'IV_LZ4'}) {
$logger->info("$username lz4: available");
pu
13 matches
Mail list logo
