Re: [Openvpn-devel] [PATCH v5 1/7] Introduce buffer_write_file()

2018-08-06 Thread tincanteksup
Hi, One typo inline On 06/08/18 09:02, Steffan Karger wrote: Rewrite buf_write_string_file to buffer_write_file, which is simpler to use and can deal with not-null-terminated strings. Mostly implemented so this can be easily reused for tls-crypt-v2 (client) key files. Signed-off-by: Steffan

[Openvpn-devel] [PATCH v5 2/7] tls-crypt-v2: add specification to doc/

2018-08-06 Thread Steffan Karger
This is a preliminary description of tls-crypt-v2. It should give a good impression about the reasoning and design behind tls-crypt-v2, but might need some polishing and updating. Signed-off-by: Steffan Karger --- v3: Include length in WKc v4: Clarify metadata handling v5: Typo fixes (thanks tin

[Openvpn-devel] [PATCH v5 1/7] Introduce buffer_write_file()

2018-08-06 Thread Steffan Karger
Rewrite buf_write_string_file to buffer_write_file, which is simpler to use and can deal with not-null-terminated strings. Mostly implemented so this can be easily reused for tls-crypt-v2 (client) key files. Signed-off-by: Steffan Karger --- v3: split change out of "generate client key", reuse i

Re: [Openvpn-devel] [PATCH v3 3/7] tls-crypt-v2: generate client keys

2018-08-06 Thread Steffan Karger
Hi, On 03-08-18 17:23, tincanteksup wrote: > On 25/07/18 17:08, Steffan Karger wrote: >> @@ -2764,6 +2781,7 @@ options_postprocess_verify_ce(const struct > options *options, const struct connec > > > connec --> connect ? (This is code so I just highlight for your > consideration, I don't know)

Re: [Openvpn-devel] [PATCH v4 2/7] tls-crypt-v2: add specification to doc/

2018-08-06 Thread Steffan Karger
Hi, On 03-08-18 17:13, tincanteksup wrote: > as I spotted an error I decided to spell check this. > > Three comments in line. Thanks! I'll include fixes in v5. -Steffan -- Check out the vibrant tech community on one o