Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-18 Thread Gert Doering
Hi, On Wed, Jul 18, 2018 at 04:33:13PM +0200, Adam wrote: > It turns out, NetBSD needs similar handling of subnet topology for tun > interfaces as OpenBSD does. > > Here is a patch to fix the issue (against OpenVPN 2.4.6): This comes as a bit of surprise - has something changed here on the NetB

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-18 Thread Antonio Quartulli
Hello Adam, thanks for your change. could you please submit the patch in proper git format so that it can be easily applied? You can create a patch like that by using the "git format-patch" command after you have commited your changes (you need to clone the git repository for that). After creat

Re: [Openvpn-devel] Dynamic challenge/response questions

2018-07-18 Thread Selva Nair
Hi, On Wed, Jul 18, 2018 at 7:46 PM, Jonathan K. Bullard wrote: > I'm trying to implement dynamic challenge/response in Tunnelblick and > have some questions. I've been using the management-interface > documentation [1] as my guide. > > 1. Is what the management interface sends something like (al

[Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-18 Thread Adam
Greetings, It turns out, NetBSD needs similar handling of subnet topology for tun interfaces as OpenBSD does. Here is a patch to fix the issue (against OpenVPN 2.4.6): patch-src_openvpn_tun.c Description: Binary data Kind regards, Adam

[Openvpn-devel] Dynamic challenge/response questions

2018-07-18 Thread Jonathan K. Bullard
I'm trying to implement dynamic challenge/response in Tunnelblick and have some questions. I've been using the management-interface documentation [1] as my guide. 1. Is what the management interface sends something like (all on one line): >PASSWORD:Verification Failed: 'Auth' >['CRV1:R,E:Om01u7F

Re: [Openvpn-devel] [PATCH v2] Fix typo in IPv6 address in comment.

2018-07-18 Thread Gert Doering
Hi, should have tagged this better - quite obviously this is for tap-windows6, and since nobody complained about fixing bugs in comments, I've applied lazy ACK rules, merge & and pushed it. commit c8bea201a8975e247cfc910131f6539f5add9277 (tap-windows6 has a slightly weird process with "developme

[Openvpn-devel] [PATCH applied] Re: Remove unneeded newline in debug message in reliable.c

2018-07-18 Thread Gert Doering
Acked-by: Gert Doering "obvious fix", but if you're used to debugging with printf(), these newlines slip in... :-) - thanks for fixing. Your patch has been applied to the master branch. commit 3e5561d34099f28a759865efff0523005116b6a1 Author: Gert van Dijk Date: Wed Jul 18 16:27:53 2018 +0200

[Openvpn-devel] [PATCH applied] Re: Make second parameter to reliable_send_purge() const

2018-07-18 Thread Gert Doering
Acked-by: Gert Doering Code doesn't modify *ack, so we can as well tell the compiler about it :) Your patch has been applied to the master branch (this is not a bugfix and not a long-term stability thing or documentation update, so it does not need to go to 2.4) commit 0f83b5e33ed63fee9f8de384

[Openvpn-devel] [PATCH applied] Re: Minor reliability layer documentation fixes

2018-07-18 Thread Gert Doering
Acked-by: Gert Doering That was actually fairly easy as I did not have to understand anything, just notice that there were typos, funny english, etc. :-) Your patch has been applied to the master and release/2.4 branch. commit df612f634a7e2e542e4393601520f7dbb0eb327f (master) commit 52e6de50a67

[Openvpn-devel] [PATCH 2/3] Make second parameter to reliable_send_purge() const

2018-07-18 Thread Steffan Karger
From: Gert van Dijk Signed-off-by: Steffan Karger --- src/openvpn/reliable.c | 2 +- src/openvpn/reliable.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c index b62ab54..d295076 100644 --- a/src/openvpn/reliable.c +++ b/src

[Openvpn-devel] [PATCH 3/3] Remove unneeded newline in debug message in reliable.c

2018-07-18 Thread Steffan Karger
From: Gert van Dijk Signed-off-by: Steffan Karger --- src/openvpn/reliable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c index d295076..a7f4ed9 100644 --- a/src/openvpn/reliable.c +++ b/src/openvpn/reliable.c @@ -462,7 +462

[Openvpn-devel] [PATCH 1/3] Minor reliability layer documentation fixes

2018-07-18 Thread Steffan Karger
From: Gert van Dijk Signed-off-by: Steffan Karger --- doc/doxygen/doc_protocol_overview.h | 2 +- src/openvpn/ssl.c | 4 ++-- src/openvpn/ssl.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/doxygen/doc_protocol_overview.h b/doc/d

[Openvpn-devel] [PATCH] Documentation, debug and const-correctness fixes

2018-07-18 Thread Steffan Karger
Hi, The following three patches contain a number of minor fixes. They were originally written by Gert van Dijk, but I have the honor to provide them to you. So I added the signed-off-by line. All improvements are Gert's, all bugs are my fault ;-) -Steffan

Re: [Openvpn-devel] TAP driver on Windows 2016 Server

2018-07-18 Thread Simon Rozman
Hi, > So we need either auto-detection (=best) or separate installers. I will do the > latter for starters so that my vacation is not ruined. But soon after we should > switch to the MSI-based installer with OS- auto-detection. Excellent. Awaiting binaries, so I can prepare the packages to test.

Re: [Openvpn-devel] TAP driver on Windows 2016 Server

2018-07-18 Thread Samuli Seppänen
Il 14/07/2018 20:22, Simon Rozman ha scritto: > Hi! > > Does anybody have some specific Windows 2016 Server release and build > numbers from which on they require HLK certified driver? Or, do all Windows > 2016 Server versions require HLK certified drivers from initial release on? > > I am adding