Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-05 Thread Antonio Quartulli
Hi Steffan and thanks for the review, On 06/07/18 04:22, Steffan Karger wrote: >> +struct buffer >> +keyfile_to_buffer(const char *file, int max_size, struct gc_arena *gc) >> +{ >> +size_t size; >> +struct buffer in = alloc_buf_gc(max_size, gc); >> +int fd = platform_open(file, O_RDONL

[Openvpn-devel] [PATCH applied] Re: Move file-related functions from misc.c to platform.c

2018-07-05 Thread Gert Doering
Acked-by: Gert Doering "only moving stuff around (+renaming), reason given makes sense, passes t_client and cmocka tests" Your patch has been applied to the master branch. commit b7bea782f3356dbd82613dc8f38fd4ef0bc714ca Author: Steffan Karger Date: Wed Jul 4 19:53:56 2018 +0200 Move fil

Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-05 Thread Steffan Karger
Hi Antonio, On 05-06-18 10:14, Antonio Quartulli wrote: > In preparation to having tls-auth/crypt keys per connection > block, it is important to ensure that such material is always > reloaded upon SIGUSR1, no matter if `persist-key` was specified > or not. > > This is required because when movin