Re: [Openvpn-devel] [PATCH] Specify platform and version on command line.

2018-04-13 Thread Arne Schwabe
Am 13.04.2018 um 19:23 schrieb Micah Morton: > From 557d2e73bf21ddb9d07b43f716c7914d610e7392 Mon Sep 17 00:00:00 2001 > From: Micah Morton mailto:mort...@chromium.org>> > Date: Fri, 13 Apr 2018 09:55:22 -0700 > Subject: [PATCH] Specify platform and version on command line. > > Add --iv-plat and --i

Re: [Openvpn-devel] [PATCH] Specify platform and version on command line.

2018-04-13 Thread Gert Doering
Hi, On Fri, Apr 13, 2018 at 12:34:15PM -0700, Micah Morton wrote: > @gert: > > From the help message: "--setenv name value : Set a custom environmental > variable to pass to script." > > --setenv appears to set string values for scripts only, not for the main > openvpn process (which is reading

Re: [Openvpn-devel] [PATCH] Specify platform and version on command line.

2018-04-13 Thread Micah Morton
@gert: >From the help message: "--setenv name value : Set a custom environmental variable to pass to script." --setenv appears to set string values for scripts only, not for the main openvpn process (which is reading them in the push_peer_info() function). Starting a test openvpn server with `--s

Re: [Openvpn-devel] [PATCH] Specify platform and version on command line.

2018-04-13 Thread Gert Doering
Hi, On Fri, Apr 13, 2018 at 10:23:03AM -0700, Micah Morton wrote: > From 557d2e73bf21ddb9d07b43f716c7914d610e7392 Mon Sep 17 00:00:00 2001 > From: Micah Morton > Date: Fri, 13 Apr 2018 09:55:22 -0700 > Subject: [PATCH] Specify platform and version on command line. > > Add --iv-plat and --iv-plat

Re: [Openvpn-devel] [PATCH] Specify platform and version on command line.

2018-04-13 Thread Jonathan K. Bullard
Hi. On Fri, Apr 13, 2018 at 1:23 PM, Micah Morton wrote: > From 557d2e73bf21ddb9d07b43f716c7914d610e7392 Mon Sep 17 00:00:00 2001 > From: Micah Morton > Date: Fri, 13 Apr 2018 09:55:22 -0700 > Subject: [PATCH] Specify platform and version on command line. > > Add --iv-plat and --iv-plat-rel comm

[Openvpn-devel] [PATCH] Specify platform and version on command line.

2018-04-13 Thread Micah Morton
>From 557d2e73bf21ddb9d07b43f716c7914d610e7392 Mon Sep 17 00:00:00 2001 From: Micah Morton Date: Fri, 13 Apr 2018 09:55:22 -0700 Subject: [PATCH] Specify platform and version on command line. Add --iv-plat and --iv-plat-rel command line args, and use the values passed to these args to set IV_PLAT

Re: [Openvpn-devel] Viscosity patch to TAP driver

2018-04-13 Thread Marvin
>> Note: active-ftp NAT will never be merged - that is way too intrusive. Yes, we realize that. That is why we didn't pursue acceptance any further. But we still require it because we have to support a large number (currently around 3000) of legacy devices that cannot be changed away from active-

Re: [Openvpn-devel] Viscosity patch to TAP driver

2018-04-13 Thread Gert Doering
Hi, On Fri, Apr 13, 2018 at 10:24:18AM -0700, Marvin wrote: > Only that here we need to run Gava's patches for active-ftp and client-nat > (submitted to openvpn-dev several years ago but not accepted). He has not > had time to port those patches to 2.4.x yet. So for now we are stuck at > 2.3.18.

Re: [Openvpn-devel] Viscosity patch to TAP driver

2018-04-13 Thread Marvin
HI Gert, Only that here we need to run Gava's patches for active-ftp and client-nat (submitted to openvpn-dev several years ago but not accepted). He has not had time to port those patches to 2.4.x yet. So for now we are stuck at 2.3.18. Marvin On Fri, Apr 13, 2018 at 10:10 AM, Gert Doering w

Re: [Openvpn-devel] Viscosity patch to TAP driver

2018-04-13 Thread Gert Doering
Hi, On Fri, Apr 13, 2018 at 10:03:55AM -0700, Marvin wrote: > Would there be any problem with updating the tap-windows6 to the Viscosity > patched version on an older openvpn build (e.g. 2.3.18 on Windows 10)? "Why?" There is nothing in 2.3.x (... that we are aware of) that makes it more suitabl

Re: [Openvpn-devel] Viscosity patch to TAP driver

2018-04-13 Thread Marvin
Hi Guys, Would there be any problem with updating the tap-windows6 to the Viscosity patched version on an older openvpn build (e.g. 2.3.18 on Windows 10)? Thanks, Marvin On Thu, Apr 12, 2018 at 8:45 PM, Eric Thorpe wrote: > Hi Gert, > > PR #47 has been submitted to tap-windows6 on github. > >

Re: [Openvpn-devel] [PATCH] Change quoted to angled form when #including external .h files

2018-04-13 Thread Simon Rozman
May I ask what the rationale is for this change? Use of angled and quoted form of #include filenames is mostly consistent across the OpenVPN source (src/openvpn) with those few exceptions fixed by this proposed patch. The rationale for this change is unification of #include sentences. Regard

Re: [Openvpn-devel] [PATCH] Change quoted to angled form when #including external .h files

2018-04-13 Thread David Sommerseth
On 13/04/18 17:55, Simon Rozman wrote: > --- > src/openvpn/comp-lz4.c | 2 +- > src/openvpn/lzo.h | 8 > src/openvpn/memdbg.h | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/openvpn/comp-lz4.c b/src/openvpn/comp-lz4.c > index f2916bdd..f52fdbfb 1

[Openvpn-devel] [PATCH] Change quoted to angled form when #including external .h files

2018-04-13 Thread Simon Rozman
--- src/openvpn/comp-lz4.c | 2 +- src/openvpn/lzo.h | 8 src/openvpn/memdbg.h | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/openvpn/comp-lz4.c b/src/openvpn/comp-lz4.c index f2916bdd..f52fdbfb 100644 --- a/src/openvpn/comp-lz4.c +++ b/src/openvpn/com

Re: [Openvpn-devel] [PATCH] Add missing (but optional) escape backslash to sed replace string

2018-04-13 Thread Gert Doering
Hi, On Fri, Apr 13, 2018 at 05:29:15PM +0200, Simon Rozman wrote: > #ifdef NEED_COMPAT_LZ4 > EOF > -sed 's/\"lz4\.h\"/\"compat-lz4.h"/' "$LZ4_C" > +sed 's/\"lz4\.h\"/\"compat-lz4.h\"/' "$LZ4_C" TBH, I think all the backslashes before a double quote (") should *go*. Nothing special abou

[Openvpn-devel] [PATCH] Add missing (but optional) escape backslash to sed replace string

2018-04-13 Thread Simon Rozman
--- dev-tools/lz4-rebaser.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-tools/lz4-rebaser.sh b/dev-tools/lz4-rebaser.sh index 03debcb..3771639 100755 --- a/dev-tools/lz4-rebaser.sh +++ b/dev-tools/lz4-rebaser.sh @@ -58,7 +58,7 @@ echo "* Porting upstream lz4.c to compa

[Openvpn-devel] [PATCH v4] Add Interactive Service developer documentation

2018-04-13 Thread Simon Rozman
The OpenVPN Interactive Service documentation from https://community.openvpn.net/openvpn/wiki/OpenVPNInteractiveService was upgraded with a description of the client-service communication flow, service registry configuration, and non-default instance installation. --- doc/interactive-service-notes

[Openvpn-devel] [PATCH v2 09/13] Signed/unsigned warnings of MSVC resolved

2018-04-13 Thread Simon Rozman
This patch fixes the signed/unsigned comparison warnings discovered when compiling openvpnserv using MSVC. Wherever possible, it changes iterator and/or size variables to a more appropriate type, or uses type-casting when it is safe to do so. --- src/openvpnserv/automatic.c | 2 +- src/openvpns

[Openvpn-devel] [PATCH v3] Add Interactive Service developer documentation

2018-04-13 Thread Simon Rozman
The OpenVPN Interactive Service documentation from https://community.openvpn.net/openvpn/wiki/OpenVPNInteractiveService was upgraded with a description of the client-service communication flow, service registry configuration, and non-default instance installation. --- doc/Makefile.am