Re: [Openvpn-devel] [PATCH] Improve management-external-key/cert error handling

2018-03-08 Thread Selva Nair
Hi, I wanted to give this a quick test, but it doesn't apply. It seems you have patch 116 (Antonio's "inline-tag changed to bool" patch) in your local repo. By the way, the M_FATAL after management_query_cert() looks like a regression. One problem with these FATAL exits is that it makes it hard

[Openvpn-devel] [PATCH v2] tls-crypt-v2: add specification to doc/

2018-03-08 Thread Steffan Karger
From: Steffan Karger This is a preliminary description of tls-crypt-v2. It should give a good impression about the reasoning and design behind tls-crypt-v2, but might need some polishing and updating. Signed-off-by: Steffan Karger --- v2: update text for --tls-crypt-v2-genkey, fix typo doc/t

[Openvpn-devel] [PATCH] Improve management-external-key/cert error handling

2018-03-08 Thread Steffan Karger
Check the return values of management_query_cert() and tls_ctx_use_external_private_key(), and error out with a more descriptive error message. To do so, we make the openssl-backed implementation of tls_ctx_use_external_private_key() not throw fatal error anymore. (And fix line wrapping while tou

[Openvpn-devel] [PATCH] Allow changing cipher from a ccd file

2018-03-08 Thread Steffan Karger
As described in msg <374a7eb7-f539-5231-623b-41f208ed8...@belkam.com> on openvpn-devel@lists.sourceforge.net, clients that are compiled with --disable-occ (included in --enable-small) won't send an options string. Without the options string, the 2.4 server doesn't know which cipher to use for poor

Re: [Openvpn-devel] [PATCH applied] Re: Move env helper functions into their own module/file

2018-03-08 Thread Gert Doering
Hi, *this* mail should have never gone out, it was the first draft yesterday after which I noticed that it failed cmocka testing... so, please ignore it. git head is commit 68b97b25e4c479156d697bf3df90a4b68fbbbcea (HEAD -> master, stable/master, gitlab/master, github/master, delta2/master) Aut

[Openvpn-devel] [PATCH applied] Re: Move env helper functions into their own module/file

2018-03-08 Thread Gert Doering
Acked-by: Gert Doering Does what it says on the lid: code is moved 1:1 with no code changes, and only #include lines are adjusted elsewhere (which is actually painful to review in this case, as the "moved out" stuff was scattered along misc.c and parts ended in env_set.h, so "plain diff" between

[Openvpn-devel] [PATCH applied] Re: Move env helper functions into their own module/file

2018-03-08 Thread Gert Doering
Acked-by: Gert Doering Does what it says on the lid: code is moved 1:1 with no code changes, and only #include lines are adjusted elsewhere (which is actually painful to review in this case, as the "moved out" stuff was scattered along misc.c and parts ended in env_set.h, so "plain diff" between

Re: [Openvpn-devel] [PATCH] Rework OpenVPN auth-token support

2018-03-08 Thread Arne Schwabe
The discussion has gone on a bit about this patch. I would like to step back and give an overview to make this mess better understandable as we have multiple problem mixed together. Current client behaviour: - (a) OpenVPN 3. Forgets auth-token on reconnect, can be told to forget auth-token during

Re: [Openvpn-devel] [PATCH 1/2] Refactor to provide struct context object inside key_method_2_read()

2018-03-08 Thread David Sommerseth
On 08/03/18 15:18, Arne Schwabe wrote: > Am 31.10.16 um 13:51 schrieb David Sommerseth: >> This refactors the call chain of tls_multi_process(), tls_process() >> and key_method_2_read() so the the latter function have access >> to the struct context object. >> >> This change is needed for the foll