[Openvpn-devel] [PATCH] Avoid overflow in wakeup time computation

2018-03-05 Thread selva . nair
From: Selva Nair Time interval arithmetic can overflow especially when user defined intervals are involved. E.g., see Trac #922. Avoid this by reordering the arithmetic operation in event_timeout_trigger(). Also avoid unnecessary casting of time variable to int. Time until wakeup is now calcula

[Openvpn-devel] [PATCH v2] Rework OpenVPN auth-token support

2018-03-05 Thread Arne Schwabe
Auth-token is documented as a token that the client will use instead of a auth-token. When using an external auth-token script and OTP authentication, it is useful to have this token survive on reconnect (e.g. mobile device roaming). On the other hand if the token does expire, the client should fa

[Openvpn-devel] [PATCH applied] Re: Management: warn about password only when the option is in use

2018-03-05 Thread Gert Doering
"Oops, stupid us..." - how fortunate that Jonathan stopped us before integrating this into 2.4.5 :-) Acked-by: Gert Doering (Stared at code, and actually tested all cases) Your patch has been applied to the master branch. commit 5961250e776194a411a8dfc1670c5c0c73107bf8 (master) commit 0533bd71

[Openvpn-devel] [PATCH] Management: warn about password only when the option is in use

2018-03-05 Thread selva . nair
From: Selva Nair Signed-off-by: Selva Nair --- src/openvpn/options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index f7995c6..c5bce9f 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -2171,7 +2171,8 @@ op

[Openvpn-devel] [PATCH] Rework OpenVPN auth-token support

2018-03-05 Thread Arne Schwabe
Auth-token is documented as a token that the client will use instead of a auth-token. When using an external auth-token script and OTP authentication, it is useful to have this token survive on reconnect (e.g. mobile device roaming). On the other hand if the token does expire, the client should f

Re: [Openvpn-devel] Getting rid of bundled lz4 ?

2018-03-05 Thread Gert Doering
Hi, On Mon, Mar 05, 2018 at 09:48:17AM +0500, ?? wrote: > It was broadcasted several times that we will get rid of bundled lz4 > someday. It was discussed whether we should do that, and there is no consensus either way, at least for now. > Currently, windows installer is bui