[Openvpn-devel] [PATCH v2 3/3] Support EC certificates with cryptoapicert

2018-02-23 Thread selva . nair
From: Selva Nair Requires openssl 1.1.0 or higher Signed-off-by: Selva Nair --- v3 of 2/3 changed the context of one chunk, so sending a v2 rebased to current master. src/openvpn/cryptoapi.c | 199 +++- 1 file changed, 198 insertions(+), 1 deletion(

Re: [Openvpn-devel] [PATCH 2/2] PF: never drop essential ICMPv6 packets

2018-02-23 Thread fragmentux
Hi, any chance this can be moved forward ? I have tested a server on Windows 10 and Linux (Various) and it all appears to work ok. The question below appears to be an outstanding issue. Thanks On 02/12/17 16:49, Antonio Quartulli wrote: On 03/12/17 00:47, Arne Schwabe wrote: Am 02.12.17

Re: [Openvpn-devel] [PATCH] mbedtls: don't use API deprecated in mbed 2.7

2018-02-23 Thread Antonio Quartulli
Hi, On 23/02/18 20:02, Steffan Karger wrote: > Since reducing dependencies usually reduces maintenance burden, I prefer > this solution. You're right here. Ok, let's keep md_full() then > >>> +{ >>> +msg(M_WARN, "WARNING: failed to personalise random"); >>> +} >>> +

Re: [Openvpn-devel] [PATCH] mbedtls: don't use API deprecated in mbed 2.7

2018-02-23 Thread Steffan Karger
Hi, Thanks for reviewing! On 23-02-18 10:17, Antonio Quartulli wrote: > On 07/02/18 20:22, Steffan Karger wrote: >> -mbedtls_sha256(cert->tbs.p, cert->tbs.len, sha256_hash, false); >> +if (0 != md_full(sha256_kt, cert->tbs.p, cert->tbs.len, >> sha256_hash)) > > Why not using mbe

Re: [Openvpn-devel] [PATCH] mbedtls: don't use API deprecated in mbed 2.7

2018-02-23 Thread Antonio Quartulli
Hi, On 07/02/18 20:22, Steffan Karger wrote: > -mbedtls_sha256(cert->tbs.p, cert->tbs.len, sha256_hash, false); > +if (0 != md_full(sha256_kt, cert->tbs.p, cert->tbs.len, sha256_hash)) Why not using mbedtls_sha256_ret() since we are already in mbedtls-specific code here? Any advan

[Openvpn-devel] [PATCH applied] Re: Move setting private key to a function in prep for EC support

2018-02-23 Thread Gert Doering
Your patch has been applied to the master branch. commit 6963570165224c4d3e18caedf570f6199651ba9d Author: Selva Nair Date: Thu Feb 22 22:03:19 2018 -0500 Move setting private key to a function in prep for EC support Signed-off-by: Selva Nair Acked-by: Steffan Karger Messa