Re: [Openvpn-devel] [PATCH v2 2/3] OpenSSL: remove some EVP_PKEY type checks

2018-01-15 Thread Selva Nair
Hi, On Mon, Jan 15, 2018 at 7:56 PM, Emmanuel Deloget wrote: > Hello Selva, > > On Tue, Jan 16, 2018 at 12:10 AM, Selva Nair wrote: > >> >> >> Can I try one last time to convince you guys to keep EVP_PKEY_id()? If I >> was targeting only 1.1.0+ that's how most of those checks would have been >>

Re: [Openvpn-devel] [PATCH v2 2/3] OpenSSL: remove some EVP_PKEY type checks

2018-01-15 Thread Emmanuel Deloget
Hello Selva, On Tue, Jan 16, 2018 at 12:10 AM, Selva Nair wrote: > > > On Mon, Jan 15, 2018 at 5:33 PM, Emmanuel Deloget wrote: > >> Hello Steffan, >> >> On Sun, Jan 14, 2018 at 11:26 AM, Steffan Karger >> wrote: >> >>> Hi, >>> >>> On 12-01-18 22:37, Emmanuel Deloget wrote: >>> > Calling EVP_K

Re: [Openvpn-devel] PKCS#11 - a little bit of help?

2018-01-15 Thread Emmanuel Deloget
Hi James, On Tue, Jan 16, 2018 at 12:18 AM, James Bottomley < james.bottom...@hansenpartnership.com> wrote: > On Tue, 2018-01-16 at 00:07 +0100, Emmanuel Deloget wrote: > > While the number of required changes were quite small (and have no > > impact on openvpn), this was quite a journey. I guess

Re: [Openvpn-devel] PKCS#11 - a little bit of help?

2018-01-15 Thread James Bottomley
On Tue, 2018-01-16 at 00:07 +0100, Emmanuel Deloget wrote: > While the number of required changes were quite small (and have no > impact on openvpn), this was quite a journey. I guess some of the > merits should go to RSA, Microsoft and Intel, for their incredible > effort in building comprehensive

Re: [Openvpn-devel] [PATCH v2 2/3] OpenSSL: remove some EVP_PKEY type checks

2018-01-15 Thread Selva Nair
On Mon, Jan 15, 2018 at 5:33 PM, Emmanuel Deloget wrote: > Hello Steffan, > > On Sun, Jan 14, 2018 at 11:26 AM, Steffan Karger > wrote: > >> Hi, >> >> On 12-01-18 22:37, Emmanuel Deloget wrote: >> > Calling EVP_KEY_id() before EVP_PKEY_get0_*() is unnecessary as >> > the same check is also perfo

Re: [Openvpn-devel] PKCS#11 - a little bit of help?

2018-01-15 Thread Emmanuel Deloget
Hello Steffan, ​​Sorry fo​r the delay - I was busy doing "things​" :) On Sat, Jan 6, 2018 at 12:11 AM, Steffan Karger wrote: > Hi Emmanuel, > > On 03-01-18 18:13, Emmanuel Deloget wrote: > > Hello Steffan, > > > > On Mon, Jan 1, 2018 at 4:36 PM, Steffan Karger > > wr

Re: [Openvpn-devel] [PATCH v2 2/3] OpenSSL: remove some EVP_PKEY type checks

2018-01-15 Thread Emmanuel Deloget
Hello Steffan, On Sun, Jan 14, 2018 at 11:26 AM, Steffan Karger wrote: > Hi, > > On 12-01-18 22:37, Emmanuel Deloget wrote: > > Calling EVP_KEY_id() before EVP_PKEY_get0_*() is unnecessary as > > the same check is also performed in the later. > > > > We also make the code a bit better by not cal

[Openvpn-devel] travis builds

2018-01-15 Thread Selva Nair
Hi, Out of the 12 or so jobs we have in the travis build matrix a few sometime fail with "write error" (happened a number of times for some local feature branches). On restarting only the failed jobs, one by one, they succeed indicating possible resource starvation? Is there anything one can do t

Re: [Openvpn-devel] [PATCH] Document missing OpenVPN states

2018-01-15 Thread Arne Schwabe
Am 15.01.2018 um 12:47 schrieb Simon Rozman: > --- > doc/management-notes.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/management-notes.txt b/doc/management-notes.txt > index a9ba18a..908b981 100644 > --- a/doc/management-notes.txt > +++ b/doc/management-notes.txt > @@ -362,6

[Openvpn-devel] [PATCH] Document missing OpenVPN states

2018-01-15 Thread Simon Rozman
--- doc/management-notes.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/management-notes.txt b/doc/management-notes.txt index a9ba18a..908b981 100644 --- a/doc/management-notes.txt +++ b/doc/management-notes.txt @@ -362,6 +362,8 @@ ADD_ROUTES-- Adding routes to system. CONNECTE

Re: [Openvpn-devel] [PATCH v2] travis-ci: modify openssl build script to support openssl-1.1.0

2018-01-15 Thread Steffan Karger
Hi, On 15-01-18 09:05, Ilya Shipitsin wrote: > get rid of no-multilib, as it is not supported on openssl-1.1.0 > > Signed-off-by: Ilya Shipitsin > --- > v2: get rid of no-multilib instead of including it conditionally, > thanks to Steffan Karger > > .travis/build-deps.sh | 2 +- > 1 file chang

Re: [Openvpn-devel] [PATCH] travis-ci: modify openssl build script to support openssl-1.1.0

2018-01-15 Thread Илья Шипицин
I've built an installer without "no-multilib" and tested on both x86 and x64. 2018-01-14 23:33 GMT+05:00 Илья Шипицин : > > > 2018-01-14 21:05 GMT+05:00 Steffan Karger : > >> Hi, >> >> On 14-01-18 15:06, Ilya Shipitsin wrote: >> > no-multilib is only supported on openssl-1.0.X, do not use it >> >

[Openvpn-devel] [PATCH v2] travis-ci: modify openssl build script to support openssl-1.1.0

2018-01-15 Thread Ilya Shipitsin
get rid of no-multilib, as it is not supported on openssl-1.1.0 Signed-off-by: Ilya Shipitsin --- v2: get rid of no-multilib instead of including it conditionally, thanks to Steffan Karger .travis/build-deps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis/build-de