Re: [Openvpn-devel] [PATCH 3/4 v2] Don't throw fatal errors from create_temp_file()

On 02/11/17 06:03, Steffan Karger wrote: > From: Steffan Karger > > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In such cases we > should not exit the process, but just reject the connecting client. > > This co

Re: [Openvpn-devel] [PATCH 1/4 v3] pf: clean up temporary files if plugin init fails

On 02/11/17 06:03, Steffan Karger wrote: > From: Steffan Karger > > close_instance() tries to remove the file in c2.pf.filename, but that only > works if we actually set that if we fail. So, set that filename as soon > as we know we've created the file. > > Signed-off-by: Steffan Karger Ack

Re: [Openvpn-devel] [PATCH 4/4 v3] create_temp_file/gen_path: prevent memory leak if gc == NULL

Hi Steffan, patch looks good, but I have just one comment below On 02/11/17 06:03, Steffan Karger wrote: > If gc == NULL, the data allocated in the alloc_gc_buf() call in > create_temp_file or the string_mod_const call in gen_path would never > be free'd. > > These functions are currently never

Re: [Openvpn-devel] [PATCH 2/4 v2] pf: reject client if PF plugin is configured, but init fails

On 02/11/17 06:03, Steffan Karger wrote: > This changes the behavior for pf plugins: instead of just not initializing > the firewall rules and happily continuing, this now rejects the client in > the case of an (unlikely) failure to initialize the pf. > > Signed-off-by: Steffan Karger Acked-by

Re: [Openvpn-devel] [PATCH v2] openvpnserv: Add support for multi-instances

Hi > > > > +static const SERVICE_TABLE_ENTRY > > > + dispatchTable_automatic[] = { > > > +{ TEXT(""), ServiceStartAutomaticOwn }, > > > +{ NULL, NULL } > > > +}; > > > > Agreed this array has to live beyond the for loop, but

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, > The best time to re-factor a function would be when a a new use case needs > to change its semantics. Apart from the ill-chosen -err as a return value, > currently it returns 0 if automatic metric is in use, making it impossible to > use > it as a generic function to find the current metri

Re: [Openvpn-devel] [PATCH] openvpnserv: Add support for multi-instances

Sorry, I forgot to label it [PATCH v3]. :( Best regards, Simon > -Original Message- > From: Simon Rozman [mailto:si...@rozman.si] > Sent: Wednesday, November 08, 2017 7:42 PM > To: openvpn-devel@lists.sourceforge.net > Cc: Simon Rozman > Subject: [PATCH] openvpnserv: Add support for multi

[Openvpn-devel] [PATCH] openvpnserv: Add support for multi-instances

While openvpn.exe can run multiple concurrent processes, openvpnserv.exe is usually only one single globally unique running process. This patch extends openvpnserv.exe to support multiple service instances in parallel allowing side-by-side OpenVPN installations. Alternate instances must be instal

Re: [Openvpn-devel] [PATCH v2] openvpnserv: Add support for multi-instances

Hi, > >  static SERVICE_STATUS_HANDLE service; -static SERVICE_STATUS status; > > +static SERVICE_STATUS status = { SERVICE_WIN32_SHARE_PROCESS }; > > While this is correct, making use of C99's designated init like > >       {.dwServiceType = SERVICE_WIN32_SHARE_PROCESS} would be better > and cl

Re: [Openvpn-devel] patchwork

Hi, On Wed, Nov 8, 2017 at 11:18 AM, Gert Doering wrote: > Hi, > > On Wed, Nov 08, 2017 at 11:07:16AM -0500, Selva wrote: > > Confused as to how patchwork works: > > Welcome to the club :-) > I already feel better :) > > I had some ideas how it should work (like, picking up my "applied" mails

Re: [Openvpn-devel] [PATCH 1/1] openssl: add engine method for loading the key

On Wed, 2017-11-08 at 13:27 +0100, David Sommerseth wrote: > I need to spend a bit more time to fully grasp the UI get/set calls > and the related implementation.  But what is done in regards to > password retrieving in ui_read() makes sense to me. How to use UI methods is (unsurprisingly) badly d

Re: [Openvpn-devel] patchwork

Hi, On Wed, Nov 08, 2017 at 11:07:16AM -0500, Selva wrote: > Confused as to how patchwork works: Welcome to the club :-) I had some ideas how it should work (like, picking up my "applied" mails and auto-closing patches) but right now it's refusing to do so - I think we need more tweaking there.

[Openvpn-devel] patchwork

Hi, Confused as to how patchwork works: @samuli or anyone else: is there a way to get previous versions of a patch superseded when a new one is sent to the same thread? Doesn't appear to happen automatically -- I've manually set some such as superseded. And when a v2 is requested is it ok to set

[Openvpn-devel] [PATCH applied] Re: doxygen: add make target and use relative paths

ACK. "Does what it says on the lid", easy access to documentation is good :-) Tried in-tree and out-of-tree builds, and both gave me a nice HTML and Latex documentation. "make distclean" now works as well, as does "make distcheck" :-) Your patch has been applied to the master branch. commit 6

Re: [Openvpn-devel] [PATCH 1/1] openssl: add engine method for loading the key

On 04/11/17 20:34, Selva wrote: > > > On Sat, Nov 4, 2017 at 1:58 PM, Gert Doering > wrote: > > Hi, > > On Wed, Nov 01, 2017 at 07:24:02PM +0100, Steffan Karger wrote: > > This looks like it should use our user query wrappers from (e.g.) > > console.

[Openvpn-devel] [PATCH v3] doxygen: add make target and use relative paths

Add a make target, such that 'make doxygen' works (both for in-tree and out-of-tree builds). This now generates the doxygen in doc/doxygen/, rather than in doxygen/. While doing so, instead of genering docs with full path names (e.g. /home/steffan/dev/openvpn/src/openvpn/crypto.h), use a relative

Re: [Openvpn-devel] [PATCH v2] doxygen: add make target and use relative paths

2017-11-08 15:01 GMT+05:00 Steffan Karger : > Add a make target, such that 'make doxygen' works (both for in-tree and > out-of-tree builds). > should we add both variants of 'make doxygen' to travis-ci matrix ? > > While doing so, instead of genering docs with full path names (e.g. > /home/ste

[Openvpn-devel] [PATCH v2] doxygen: add make target and use relative paths

Add a make target, such that 'make doxygen' works (both for in-tree and out-of-tree builds). While doing so, instead of genering docs with full path names (e.g. /home/steffan/dev/openvpn/src/openvpn/crypto.h), use a relative path wrt the project root (e.g. src/openvpn/crypto.h) in the generated do

Re: [Openvpn-devel] [PATCH 2/2] doxygen: add make target

Hi, On Wed, Nov 01, 2017 at 01:55:12PM +0100, Steffan Karger wrote: > Add a make target, such that 'make doxygen' works (both for in-tree and > out-of-tree builds). The relative path used for INPUT= has some funky side effects if another project happens to be checked out "nearby" - I had openvpn

Re: [Openvpn-devel] [PATCH 1/2] doxygen: use relative paths from the project root

Hi, On Wed, Nov 01, 2017 at 01:55:11PM +0100, Steffan Karger wrote: > Instead of genering docs with full path names (e.g. > /home/steffan/dev/openvpn/src/openvpn/crypto.h), use a relative path wrt > the project root (e.g. src/openvpn/crypto.h). This makes the generated > doxygen easier to read.