Re: [Openvpn-devel] [PATCH 0/1] add engine keys keys

2017-10-29 Thread Selva
Hi, On Sun, Oct 29, 2017 at 12:04 PM, James Bottomley wrote: > On Sun, 2017-10-29 at 16:24 +0100, Gert Doering wrote: > > Hi, > > > > On Sat, Oct 28, 2017 at 01:02:27PM +0100, James Bottomley wrote: > > > > > > Engine keys are an openssl concept for a key file which can only be > > > understood

Re: [Openvpn-devel] Windows build 2.4.4 fails signature verification

2017-10-29 Thread Lefty
Thank you Samuli. I mis-read the description and thought that your "new key" was being used for all Windows releases. The download verified correctly with the mailing list key. -Lefty On Fri, Oct 27, 2017 at 12:31 AM, Samuli Seppänen wrote: > On 27/10/2017 08:20, Lefty wrote: > > Hi all, > > >

Re: [Openvpn-devel] [PATCH 0/1] add engine keys keys

2017-10-29 Thread Arne Schwabe
Am 29.10.17 um 16:24 schrieb Gert Doering: > Hi, > > On Sat, Oct 28, 2017 at 01:02:27PM +0100, James Bottomley wrote: >> Engine keys are an openssl concept for a key file which can only be >> understood by an engine (usually because it's been wrapped by the >> engine itself).  We use this for TPM

Re: [Openvpn-devel] [PATCH 0/1] add engine keys keys

2017-10-29 Thread James Bottomley
On Sun, 2017-10-29 at 16:24 +0100, Gert Doering wrote: > Hi, > > On Sat, Oct 28, 2017 at 01:02:27PM +0100, James Bottomley wrote: > > > > Engine keys are an openssl concept for a key file which can only be > > understood by an engine (usually because it's been wrapped by the > > engine itself).  

Re: [Openvpn-devel] [PATCH 1/1] openssl: add engine method for loading the key

2017-10-29 Thread James Bottomley
On Sun, 2017-10-29 at 23:15 +0800, Antonio Quartulli wrote: > James, > > could you please resend a full patch, so to have a better overview of > the whole change? Sure thing.  It's below. James --- From d55d6f50cd156ac8e5cdead1b5c03569885158f6 Mon Sep 17 00:00:00 2001 From: James Bottomley Da

[Openvpn-devel] [PATCH] autoconf: Fix engine checks for openssl 1.1

2017-10-29 Thread James Bottomley
In openssl 1.1, ENGINE_cleanup became a #define instead of a function (because it's no longer needed as engines are self cleaning). Update the autoconf.ac script to check for ENGINE_cleanup as a declaration to avoid falsely underfinig HAVE_OPENSSL_ENGINE in openssl 1.1+ Signed-off-by: James Botto

Re: [Openvpn-devel] [PATCH 0/1] add engine keys keys

2017-10-29 Thread Gert Doering
Hi, On Sat, Oct 28, 2017 at 01:02:27PM +0100, James Bottomley wrote: > Engine keys are an openssl concept for a key file which can only be > understood by an engine (usually because it's been wrapped by the > engine itself).  We use this for TPM engine keys, so you can either > generate them withi

Re: [Openvpn-devel] [PATCH 1/1] openssl: add engine method for loading the key

2017-10-29 Thread Antonio Quartulli
James, could you please resend a full patch, so to have a better overview of the whole change? Thanks! On 29/10/17 23:07, James Bottomley wrote: > On Sun, 2017-10-29 at 17:34 +0500, Илья Шипицин wrote: >> 2017-10-28 17:03 GMT+05:00 James Bottomley < >> james.bottom...@hansenpartnership.com>: >>

Re: [Openvpn-devel] [PATCH 1/1] openssl: add engine method for loading the key

2017-10-29 Thread James Bottomley
On Sun, 2017-10-29 at 17:34 +0500, Илья Шипицин wrote: > 2017-10-28 17:03 GMT+05:00 James Bottomley < > james.bottom...@hansenpartnership.com>: > > > > > As well as doing crypto acceleration, engines can also be used to > > load > > key files.  If the engine is set, and the private key loading fa

Re: [Openvpn-devel] [PATCH 1/1] openssl: add engine method for loading the key

2017-10-29 Thread Илья Шипицин
2017-10-28 17:03 GMT+05:00 James Bottomley < james.bottom...@hansenpartnership.com>: > As well as doing crypto acceleration, engines can also be used to load > key files. If the engine is set, and the private key loading fails > for bio methods, this patch makes openvpn try to get the engine to >