Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

2017-10-16 23:17 GMT+05:00 Selva : > Hi, > > On Mon, Oct 16, 2017 at 12:57 PM, Gert Doering > wrote: > >> Hi, >> >> On Mon, Oct 16, 2017 at 11:33:02AM -0400, Selva wrote: >> > I did a quick test on ubuntu trusty (14.04.05 LTS), and as you pointed >> > out, it fails while >> > compiling block_dns

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, On Mon, Oct 16, 2017 at 12:57 PM, Gert Doering wrote: > Hi, > > On Mon, Oct 16, 2017 at 11:33:02AM -0400, Selva wrote: > > I did a quick test on ubuntu trusty (14.04.05 LTS), and as you pointed > > out, it fails while > > compiling block_dns.c because of some errors in the headers for the >

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

2017-10-16 20:33 GMT+05:00 Selva : > > Hi > > On Mon, Oct 16, 2017 at 4:22 AM, Илья Шипицин > wrote: > >> >> >> 2017-10-16 13:05 GMT+05:00 Samuli Seppänen : >> >>> On 13/10/2017 20:48, Selva wrote: >>> >>> > @samuli: Which versions of mingw-w64 should we test against to ensure >>> > release and s

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, On Mon, Oct 16, 2017 at 11:33:02AM -0400, Selva wrote: > I did a quick test on ubuntu trusty (14.04.05 LTS), and as you pointed > out, it fails while > compiling block_dns.c because of some errors in the headers for the > windows filtering platform API. All the bits are there so its possible

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi On Mon, Oct 16, 2017 at 4:22 AM, Илья Шипицин wrote: > > > 2017-10-16 13:05 GMT+05:00 Samuli Seppänen : > >> On 13/10/2017 20:48, Selva wrote: >> >> > @samuli: Which versions of mingw-w64 should we test against to ensure >> > release and snapshot builds would succeed? >> >> Right now _we_ use

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, On Mon, Oct 16, 2017 at 4:05 AM, Samuli Seppänen wrote: > On 13/10/2017 20:48, Selva wrote: > > > @samuli: Which versions of mingw-w64 should we test against to ensure > > release and snapshot builds would succeed? > > Right now _we_ use Ubuntu 16.04 for building: > > mingw-w64 4.0.4 > g

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

2017-10-16 13:05 GMT+05:00 Samuli Seppänen : > On 13/10/2017 20:48, Selva wrote: > > Hi, > > > > On Fri, Oct 13, 2017 at 12:55 AM, Simon Rozman > > wrote: > > ... > > > > > > > As said above, I would have replaced all _snwprintf and snwprintf > by > > > swprintf >

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

On 13/10/2017 20:48, Selva wrote: > Hi, > > On Fri, Oct 13, 2017 at 12:55 AM, Simon Rozman > wrote: > ... > > > > As said above, I would have replaced all _snwprintf and snwprintf by > > swprintf > > and avoided the #define. That has the added advantage that