Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-13 Thread Simon Rozman
Hi, > > 1. Should I post all MSVC-specific file changes as a one single large > patch? (.sln/.vcxproj/.bat files, without .h/.c) > > That would be my preference. But for the existing patches (unless they are > stale), keep 'em as they are. Then, you can safely discard all my patches that

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

2017-10-13 Thread Selva
Hi, On Fri, Oct 13, 2017 at 12:55 AM, Simon Rozman wrote: ... > > > As said above, I would have replaced all _snwprintf and snwprintf by > > swprintf > > and avoided the #define. That has the added advantage that mingw builds > > also will no longer depend on the non-standard snwprintf. > > Are

Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-13 Thread Gert Doering
Hi, On Thu, Oct 12, 2017 at 11:16:33AM +, Simon Rozman wrote: > 1. Should I post all MSVC-specific file changes as a one single large > patch? (.sln/.vcxproj/.bat files, without .h/.c) That would be my preference. But for the existing patches (unless they are stale), keep 'em as they

Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-13 Thread Simon Rozman
Hi, > -Original Message- > From: Илья Шипицин [mailto:chipits...@gmail.com] > Sent: Friday, October 13, 2017 10:28 AM > To: Simon Rozman > Cc: openvpn-devel (openvpn-devel@lists.sourceforge.net) > Subject: Re: [Openvpn-devel] openvpnserv building under MSVC > > > > yep, I meant App Veyo

[Openvpn-devel] [PATCH] Uniform swprintf() across MinGW and MSVC compilers

2017-10-13 Thread Simon Rozman
Legacy _snwprintf() and snwprintf() functions replaced with ISO C swprintf(). Assigning _snwprintf() return value to unused variable was also removed at one occasion. --- src/openvpn/tun.c | 2 +- src/openvpnserv/interactive.c | 20 ++-- src/openvpnserv/validate.c

Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-13 Thread Илья Шипицин
2017-10-13 13:10 GMT+05:00 Simon Rozman : > Hi, > > > > I am learning this whole mingw-generic build environment just to be able > to test openvpn build before I submit any patch. And only now, I realized > what you probably meant below. > > > > No, I haven’t upgraded openvpn-build to build on MSV

Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-13 Thread Simon Rozman
Hi, I am learning this whole mingw-generic build environment just to be able to test openvpn build before I submit any patch. And only now, I realized what you probably meant below. No, I haven’t upgraded openvpn-build to build on MSVC yet. Let alone on App Veyor. I'd like to fix buildin