Re: [Openvpn-devel] [PATCH 3/2] create_temp_file: prevent memory leak if gc == NULL

2017-09-28 Thread Antonio Quartulli
Hi, On 28/09/17 23:54, Steffan Karger wrote: > If gc == NULL, the data allocated in the alloc_gc_buf() call would never > be free'd. The function is never called that way, but let's prevent > future problems. Same problem exists with the invocation of gen_path() a few lines below: it invokes str

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-28 Thread Antonio Quartulli
HiĀ², On 26/09/17 00:05, Steffan Karger wrote: > Hi, > > On 21-09-17 19:15, Antonio Quartulli wrote: >> On 15/09/17 05:34, Steffan Karger wrote: >>> diff --git a/src/openvpn/pf.c b/src/openvpn/pf.c >>> index 5cb002b..5fe1734 100644 >>> --- a/src/openvpn/pf.c >>> +++ b/src/openvpn/pf.c >>> @@ -639,

Re: [Openvpn-devel] suggestion: --verb 0 minor change

2017-09-28 Thread fragmentux
SF Bounced this .. resending. On 27/09/17 15:31, fragmentux wrote: On 27/09/17 14:47, fragmentux wrote: On 27/09/17 14:36, fragmentux wrote: Hi, I just upgraded a bunch of clients to 2.4.4 and although I was fairly sure they all started using the upgraded version I was not totally sure.

[Openvpn-devel] [PATCH] Fixed that "--bind ipv6only" did not work due to incorrect parameter processing. It seems that "ipv6only" did not work from the beginning.

2017-09-28 Thread hashiz
--- src/openvpn/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 3a5bccfc..5f31e7eb 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -5881,7 +5881,7 @@ add_option(struct options *options, VER

[Openvpn-devel] [PATCH 3/2] create_temp_file: prevent memory leak if gc == NULL

2017-09-28 Thread Steffan Karger
If gc == NULL, the data allocated in the alloc_gc_buf() call would never be free'd. The function is never called that way, but let's prevent future problems. Signed-off-by: Steffan Karger --- src/openvpn/misc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/openvpn/

Re: [Openvpn-devel] Too much output at --verb 0 (bug?)

2017-09-28 Thread fragmentux
SF bounced this .. resending On 27/09/17 15:57, fragmentux wrote: Hi, not sure if this really counts as a bug but .. according to the manual --verb 0 = "No output except fatal errors" This, however, is the output at --verb 0 (2.4.4) == Start client: Option 'explicit-exit-notify' in [PUSH-OPT