Re: [Openvpn-devel] [openvpn-devel] Forum upgrade problems

2017-09-18 Thread Eric Crist
The oconf stuff is something I can share. I’ll post to github this afternoon. This white space problem appears to be a known “feature”. Eric Crist > On Sep 18, 2017, at 4:26 PM, fragmentux wrote: > > Any update ? > > here is a good example of the problem: > https://forums.openvpn.net/viewtop

Re: [Openvpn-devel] [openvpn-devel] Forum upgrade problems

2017-09-18 Thread fragmentux
Any update ? here is a good example of the problem: https://forums.openvpn.net/viewtopic.php?f=6&t=24907 On 14/09/17 17:29, Eric Crist wrote: I will look into these. I'm surprised [oconf] is broken, since I wrote that myself and it is not a normal part of phpBB. Eric Crist On Sep 14, 2017,

[Openvpn-devel] [PATCH v4 2/3] merge *-inline.h files with their main header

2017-09-18 Thread Antonio Quartulli
*-inline.h files are not very useful anymore. In the attempt of cleaning up the code some more, merge them into their main header files. No functional change is part of this patch. Cc: Steffan Karger Signed-off-by: Antonio Quartulli --- v4: pf_c2c/addr_test() has been made static again src/

[Openvpn-devel] [PATCH v4 3/3] ensure function declarations are compiled with their definitions

2017-09-18 Thread Antonio Quartulli
From: Antonio Quartulli Function prototypes should be included when compiling their definitions so that it is clear to compilers and static analyzers that they are not static. This means that several declarations have to be moved to the related header files which in turn have to be included by t

[Openvpn-devel] [PATCH v4 1/3] pf: restyle pf_c2c/addr_test() to make them 'struct context' agnostic

2017-09-18 Thread Antonio Quartulli
In the attempt of getting rid of any pf-inline.h file, we need to make sure that inline functions do not trigger any circular include dependency. For this reason, avoid pf_c2c/addr_test() to be 'struct context' aware, so that pf-inline.h does not need to rely on the content of openvpn.h. Cc: Stef

Re: [Openvpn-devel] [PATCHv3 2/2] ensure function declarations are compiled with their definitions

2017-09-18 Thread Antonio Quartulli
Hi, thanks for noticing this. I think something went wrong during my last rebase. After working on this branch this morning I also got complaints from travis-ci, but I hadn't noticed that before. will fix and resend both patches. Cheers, On 18/09/17 16:31, Simon Ruderich wrote: > Hello, > > Th

Re: [Openvpn-devel] [PATCHv3 2/2] ensure function declarations are compiled with their definitions

2017-09-18 Thread Simon Ruderich
Hello, The patch contains conflict markers. On Mon, Aug 28, 2017 at 04:56:20PM +0800, Antonio Quartulli wrote: > [snip] > > diff --git a/src/openvpn/occ.h b/src/openvpn/occ.h > index 369ebac4..f81e68d7 100644 > --- a/src/openvpn/occ.h > +++ b/src/openvpn/occ.h > @@ -90,6 +90,19 @@ is_occ_msg(cons