[Openvpn-devel] [PATCH v2] Undo cipher push in client options state if cipher is rejected

2017-06-27 Thread Steffan Karger
Because of the way we re-use the options parser for both config files and pushed options, we always update the local options state when we accept an option. This resulted in a pushed cipher being rejected the first time it was pushed, but being accepted the second time. This patch is a minimal wa

Re: [Openvpn-devel] [PATCH applied] Re: travis-ci: added gcc and clang openssl-1.1.0 builds

2017-06-27 Thread Gert Doering
Hi, On Wed, Jun 21, 2017 at 10:50:00PM +0200, Steffan Karger wrote: > The following have to be cherry-picked (just tested, works without fuzz): > > 56e6bd8967d72c4374389dfd5cf32f5e3b86242c > 81ba70b39b78d7677aabab957421264800028f53 > aeac1139a34321a7f770ca20bfef886a21a89fe9 I have done this, and

[Openvpn-devel] [PATCH applied] Re: Move adjust_power_of_2() to integer.h

2017-06-27 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. (After some deliberation wrt release/2.4 - normally, a refactoring patch would not go to 2.4, but this improves our testing infrastructure and is not *rewriting* any code, just *moving* it - so I decided it makes much sense to have

[Openvpn-devel] [PATCH applied] Re: init_key_ctx: key and iv arguments can (now) be const

2017-06-27 Thread Gert Doering
Your patch has been applied to the master branch. commit 5e6e4b7d21150ea2f0738948d5a9bd0c7d910e1a Author: Steffan Karger Date: Mon Jun 19 13:51:05 2017 +0200 init_key_ctx: key and iv arguments can (now) be const Signed-off-by: Steffan Karger Acked-by: Antonio Quartulli Me

[Openvpn-devel] [PATCH applied] Re: Set tls-cipher restriction before loading certificates

2017-06-27 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. commit 26345ba61b8d5bccb1331894ab6d1468e3b09adf (master) commit 95c07b13ce112ceb8b15175fcae0d95c70e93eee (release/2.4) Author: Arne Schwabe Date: Mon Jun 26 13:13:26 2017 +0200 Set tls-cipher restriction before loading certi

Re: [Openvpn-devel] [PATCH] Undo cipher push in client options state if cipher is rejected

2017-06-27 Thread Gert Doering
Hi, On Mon, Jun 26, 2017 at 11:15:40PM +0200, Steffan Karger wrote: > Because of the way we re-use the options parser for both config files and > pushed options, we always update the local options state when we accept an > option. This resulted in a pushed cipher being rejected the first time it

Re: [Openvpn-devel] [PATCH 2/2] Parse static challenge response in auth-pam plugin

2017-06-27 Thread Selva Nair
On Mon, Jun 12, 2017 at 2:28 PM, Selva Nair wrote: > On Mon, Jun 12, 2017 at 2:14 PM, Gert Doering wrote: > >> Hi, >> >> wading through my heap of mails that did not get proper attention... >> >> On Fri, May 05, 2017 at 02:24:02PM -0400, selva.n...@gmail.com wrote: >> > From: Selva Nair >> > >>

[Openvpn-devel] [PATCH applied] Re: crypto: correct typ0 in error message

2017-06-27 Thread Gert Doering
Your patch has been applied to the master, release/2.4 and release/2.3 branch. commit 778aca3d251b6a563ffbabef95816fab863825e1 (master) commit d3c0b2b6b743ef8db37f8c63dc77ffe6b421a2df (release/2.4) commit ca870b1396a173bbb9752bbe2e69f25fa2c094af (release/2.3) Author: Antonio Quartulli Date: Tue

Re: [Openvpn-devel] [PATCH trivial] crypto: correct typ0 in error message

2017-06-27 Thread Steffan Karger
On 27-06-17 14:00, Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > src/openvpn/crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c > index 191fee8e..9f2828a4 100644 > --- a/src/openvpn/crypto.c > +++ b

[Openvpn-devel] [PATCH trivial] crypto: correct typ0 in error message

2017-06-27 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- src/openvpn/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c index 191fee8e..9f2828a4 100644 --- a/src/openvpn/crypto.c +++ b/src/openvpn/crypto.c @@ -1261,7 +1261,7 @@ read_key_file(struc

[Openvpn-devel] OpenVPN fuzzers released

2017-06-27 Thread Guido Vranken
Here is the set of fuzzers used to find the recent vulnerabilities in OpenVPN: https://github.com/guidovranken/openvpn/tree/fuzzing Not all code is covered by this set; more fuzzers need to be written in order to verify the overall security of OpenVPN. Hence, it is conceivable that more vulnerabi