[Openvpn-devel] [PATCH] Fix gateway detection with OpenBSD routing domains

2017-04-13 Thread Steven McDonald
When OpenVPN is started using a non-default routing table on OpenBSD (e.g., with 'route -T10 exec openvpn ...'), it hangs forever trying to read its default gateway from a PF_ROUTE socket. This is because rtm_tableid is not being initialised after bzeroing the rt_msghdr we write to the socket, so w

[Openvpn-devel] [PATCH] Fix broken ./configure on systems without openssl.pc

2017-04-13 Thread David Sommerseth
Commit 039a89c331e9b799 changed the OpenSSL check slightly, but that broke ./configure on systems which do not install the openssl.pc pkg-config support file. This is typically an issue on most of the BSD platforms, where the OpenSSL package from the base repository does not provide that file. We

Re: [Openvpn-devel] [PATCH v2] Add --tls-cert-profile option for mbedtls builds

2017-04-13 Thread David Sommerseth
On 13/04/17 15:37, Steffan Karger wrote: > On 13-04-17 15:09, David Sommerseth wrote: >> I'm however a bit puzzled of the "non-changes" (well, the indenting is >> changing, unless I'm blind to other changes) to --remote-cert-cu, >> --remote-cert-tls and --ns-cert-type. If we want to change the >>

Re: [Openvpn-devel] [PATCH v2] Add --tls-cert-profile option for mbedtls builds

2017-04-13 Thread Steffan Karger
On 13-04-17 15:09, David Sommerseth wrote: > I'm however a bit puzzled of the "non-changes" (well, the indenting is > changing, unless I'm blind to other changes) to --remote-cert-cu, > --remote-cert-tls and --ns-cert-type. If we want to change the > indenting, I think that should be kept in a sep

Re: [Openvpn-devel] [PATCH v2] Add --tls-cert-profile option for mbedtls builds

2017-04-13 Thread David Sommerseth
On 13/04/17 14:39, Steffan Karger wrote: > On 12-04-17 13:35, Steffan Karger wrote: >> Version 2.4.1 >> = >> - - ``--remote-cert-ku`` now only requires the certificate to have at least >> the >> - bits set of one of the values in the supplied list, instead of requiring >> an >> -

Re: [Openvpn-devel] [PATCH v2] Add --tls-cert-profile option for mbedtls builds

2017-04-13 Thread Steffan Karger
On 12-04-17 13:35, Steffan Karger wrote: > Version 2.4.1 > = > - - ``--remote-cert-ku`` now only requires the certificate to have at least > the > - bits set of one of the values in the supplied list, instead of requiring > an > - exact match to one of the values in the list. >

Re: [Openvpn-devel] [PATCH] cleanup: merge packet_id_alloc_outgoing() into packet_id_write()

2017-04-13 Thread Steffan Karger
On 19-12-16 00:01, Steffan Karger wrote: > The functions packet_id_alloc_outgoing() and packet_id_write() were > always called in tandem. Instead of forcing the caller to allocate a > packet_id_net to do so, merge the two functions. This simplifies the API > and reduces the chance on mistakes in