Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

Hi, Patch below with the requested hunks removed. Signed-off by: Eric Thorpe diff --git a/config-msvc-version.h.in b/config-msvc-version.h.in index 4bc89e7..7977cb8 100644 --- a/config-msvc-version.h.in +++ b/config-msvc-version.h.in @@ -1,8 +1,12 @@ #define PACKAGE_NAME "@PRODUCT_NAME@" -#de

Re: [Openvpn-devel] why "ifconfig" is required during build ?

On 15/03/17 16:46, Selva Nair wrote: > > You can set custom path during configure like this: > > $ IFCONFIG=/opt/hacks/bin/ifconfig ./configure This will work ... but generally this is a bit better: $ ./configure IFCONFIG=/opt/hacks/bin/ifconfig The reason is that 'make' might some times de

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

Hi, On 15-03-17 22:00, Gert Doering wrote: > On Tue, Mar 14, 2017 at 09:26:52AM +1100, Eric Thorpe wrote: >> #ifdef HAVE_CONFIG_MSVC_LOCAL_H >> #include >> diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c >> index 5549d70..bed39f3 100644 >> --- a/src/openvpn/crypto_ope

[Openvpn-devel] [PATCH] Be less picky about keyUsage extensions

We long recommended users to use --ns-cert-type to distinguish between client and server certificates, but that extension is long deprecated and now can even no longer be accurately checked in OpenSSL 1.1+. We support a more modern alternative, --remote-cert-tls (which expands to --remote-cert-ku

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

Hi, thanks for your patch. I'm not exactly happy with it for a number of reasons, but it's a good way to get started. Details... On Tue, Mar 14, 2017 at 09:26:52AM +1100, Eric Thorpe wrote: [..] > diff --git a/config-msvc-version.h.in b/config-msvc-version.h.in > index 4bc89e7..7977cb8 100644 >

[Openvpn-devel] [PATCH applied] Re: Remove duplicate X509 env variables

ACK. "Stared at the code and mulled over whether it's safe" (plus ran my test set). Tested by the reporter in trac #854, so that should be good enough. Your patch has been applied to the master and release/2.4 branch. commit fd0361813cd3d5a55f3408a018e2ed776d79fef6 (master) commit 19d6cd4e63557

[Openvpn-devel] Summary of today's (Wed, 15th Mar 2017) community meeting

Hi, Here's the summary of today's IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wednesday 15th Mar 2017 Time: 20:00 CET (19:00 UTC) Planned meeting topics for this meeting were here: The nex

Re: [Openvpn-devel] why "ifconfig" is required during build ?

Hi, On Wed, Mar 15, 2017 at 08:37:12PM +0500, ?? wrote: > well, what if I will not change current (i.e. default behaviour), but > instead I will add a possibility to specify ifconfig explicitly ? What for? (If the build fails if ifconfig cannot be found, one could print a wa

Re: [Openvpn-devel] why "ifconfig" is required during build ?

2017-03-15 20:46 GMT+05:00 Selva Nair : > Hi, > > On Wed, Mar 15, 2017 at 11:37 AM, Илья Шипицин > wrote: > >> > >>> > well, it makes sense that it might be required for running openvpn. >>> but why >>> > to check it during build ? >>> >>> To find the path that we're going to call the binary with

Re: [Openvpn-devel] why "ifconfig" is required during build ?

Hi, On Wed, Mar 15, 2017 at 11:37 AM, Илья Шипицин wrote: > > >> > well, it makes sense that it might be required for running openvpn. but >> why >> > to check it during build ? >> >> To find the path that we're going to call the binary with. We do not >> rely on $PATH resolution at runtime. >>

Re: [Openvpn-devel] why "ifconfig" is required during build ?

2017-03-15 20:28 GMT+05:00 Gert Doering : > Hi, > > On Wed, Mar 15, 2017 at 08:15:08PM +0500, ?? wrote: > > I'm playing with AppVeyor, and I figured out that I have no idea why does > > "ifconfig" is checked during build process: > > > > [ilia@localhost openvpn]$ grep ifconfig

Re: [Openvpn-devel] why "ifconfig" is required during build ?

Hi, On Wed, Mar 15, 2017 at 08:15:08PM +0500, ?? wrote: > I'm playing with AppVeyor, and I figured out that I have no idea why does > "ifconfig" is checked during build process: > > [ilia@localhost openvpn]$ grep ifconfig configure.ac > AC_PATH_PROGS([IFCONFIG], [ifconfig],,

[Openvpn-devel] why "ifconfig" is required during build ?

Hello, I'm playing with AppVeyor, and I figured out that I have no idea why does "ifconfig" is checked during build process: [ilia@localhost openvpn]$ grep ifconfig configure.ac AC_PATH_PROGS([IFCONFIG], [ifconfig],, [$PATH:/usr/local/sbin:/usr/sbin:/sbin]) AC_DEFINE_UNQUOTED([IFCONFIG_PATH], ["$