Re: [Openvpn-devel] [PATCH v2] convert *_inline attributes to bool

On Tue, Jan 10, 2017 at 10:35:10PM +0100, Steffan Karger wrote: > Hi, > > In general this looks good. Some remarks inline. Please bear with me, > we're almost there ;) No worries :) and thanks for taking some time to review my patch! [CUT] > > +if (!options->extra_certs_file) > > +{ >

Re: [Openvpn-devel] [PATCH 1/2] management: >REMOTE operation would overwrite ce change indicator

On Tue, Jan 10, 2017 at 3:34 PM, David Sommerseth wrote: > If the management interface on a client received a signal while waiting > for input on the management channel, the "connection entry changed" status > would be overwritten even though nothing was changed. Which could lead > into > connec

Re: [Openvpn-devel] [PATCH v2] convert *_inline attributes to bool

Hi, In general this looks good. Some remarks inline. Please bear with me, we're almost there ;) On 27-12-16 12:24, Antonio Quartulli wrote: > Carrying around the INLINE_TAG is not really efficient, > because it requires a strcmp() to be performed every > time we want to understand if the data i

[Openvpn-devel] [PATCH (master)] reformatting: fix style in crypto*.{c, h}

Now that we have touched each and every file anyway, I decided to go over the code I regularly work with and reformat it some more by hand. This is how for I got today, and is a large enough patch I think. This commit is mostly just reordering and changing whitespace, with one exception: it remov

Re: [Openvpn-devel] [PATCH] resolving trivial issue found by clang static analyzer variable "ret" is assigned a value that is redefined later

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/01/17 20:50, Selva Nair wrote: > > On Tue, Jan 10, 2017 at 2:12 PM, David Sommerseth > > wrote: > > The attached patch is cleaning up this a bit, avoiding some of the > scoping and the not really use

[Openvpn-devel] [PATCH 2/2] management: Remove a redundant #ifdef block

Bascially removes two independent #ifdef ENABLE_MANAGEMENT blocks into a single block, which makes the logic flow more easy to read. Signed-off-by: David Sommerseth Cc: Selva Nair --- src/openvpn/init.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/openvpn/init.c

[Openvpn-devel] [PATCH 1/2] management: >REMOTE operation would overwrite ce change indicator

If the management interface on a client received a signal while waiting for input on the management channel, the "connection entry changed" status would be overwritten even though nothing was changed. Which could lead into connecting to the wrong server. This patch improves this by adding a check

Re: [Openvpn-devel] [PATCH] resolving trivial issue found by clang static analyzer variable "ret" is assigned a value that is redefined later

On Tue, Jan 10, 2017 at 2:12 PM, David Sommerseth wrote: > The attached patch is cleaning up this a bit, avoiding some of the > scoping and the not really useful 'bool ret' variable. > In the patch you correctly break out of the while() on when man-even-loop prematurely returns due to signal b

Re: [Openvpn-devel] [PATCH] resolving trivial issue found by clang static analyzer variable "ret" is assigned a value that is redefined later

On 10/01/17 09:18, Ilya Shipitsin wrote: > details can be found here: > https://delft.syzzer.nl/openvpn-scan-build/2017-01-10-20-23912-1/report-856cea.html#EndPath > --- > src/openvpn/init.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/openvpn/init.c b/src/openvpn/init.c > ind

Re: [Openvpn-devel] [PATCH] resolving trivial issue found by clang static analyzer variable "ret" is assigned a value that is redefined later

2017-01-10 20:20 GMT+05:00 Selva Nair : > > On Tue, Jan 10, 2017 at 3:18 AM, Ilya Shipitsin > wrote: > >> diff --git a/src/openvpn/init.c b/src/openvpn/init.c >> index b2547f4..5b39929 100644 >> --- a/src/openvpn/init.c >> +++ b/src/openvpn/init.c >> @@ -266,7 +266,6 @@ ce_management_query_remote

Re: [Openvpn-devel] [PATCH] resolving trivial issue found by clang static analyzer variable "ret" is assigned a value that is redefined later

On Tue, Jan 10, 2017 at 3:18 AM, Ilya Shipitsin wrote: > diff --git a/src/openvpn/init.c b/src/openvpn/init.c > index b2547f4..5b39929 100644 > --- a/src/openvpn/init.c > +++ b/src/openvpn/init.c > @@ -266,7 +266,6 @@ ce_management_query_remote(struct context *c) > management_event_l

[Openvpn-devel] [PATCH] resolving trivial issue found by clang static analyzer variable "ret" is assigned a value that is redefined later

details can be found here: https://delft.syzzer.nl/openvpn-scan-build/2017-01-10-20-23912-1/report-856cea.html#EndPath --- src/openvpn/init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index b2547f4..5b39929 100644 --- a/src/openvpn/init.c +++ b

[Openvpn-devel] [PATCH] Resolving several travis-ci issues:

* moving LD_LIBRARY_PATH as far as possible (otherwise "wget" picks it, which is not desirable) * split LD_LIBRARY_PATH into LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on operating system * removed MBEDTLS_VERSION, OPENSSL_VERSION (the last depended on nonexistent OPENSSL_VERION variable) * rem