Re: [Openvpn-devel] [PATCH] Fix user's group membership check in interactive service to work with domains

2017-01-08 Thread Selva Nair
On Sun, Jan 8, 2017 at 3:00 PM, wrote: > From: Selva Nair > > Currently the username unqualified by the domain is used to validate > a user which fails for domain users. Instead compare the user's SID > with SIDs in the Administrators group and ovpn_admin_group. > > This has the advantage that c

[Openvpn-devel] [PATCH] Fix user's group membership check in interactive service to work with domains

2017-01-08 Thread selva . nair
From: Selva Nair Currently the username unqualified by the domain is used to validate a user which fails for domain users. Instead compare the user's SID with SIDs in the Administrators group and ovpn_admin_group. This has the advantage that connection to a domain controller is not required and

Re: [Openvpn-devel] helping developers to collaborate properly

2017-01-08 Thread Steffan Karger
Hi, On 6 January 2017 at 17:49, Илья Шипицин wrote: > it seems that Contributing.md should go to .github as well, @mattock? No, I don't think so. Contributing.md is for non-github users too, and I for one would not got looking in .github/ to find contributing guidelines. As for the PR itself,

[Openvpn-devel] testers wanted! (trac#806)

2017-01-08 Thread Илья Шипицин
Hello, I want https://github.com/OpenVPN/openvpn-build/pull/70 to be merged before 2.4.1 while change itself does not look intrusive, we never did it, so "/OEM" switch may have any side effect on RTL (arabic or hebrew) or multibyte (like chinese) windows build. I created test installer: https:/