Re: [Openvpn-devel] [PATCH applied] Arm inotify only in server mode

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ACK. Also tested using the reproducer in Trac. This patch fixes the issue when OpenVPN is built using --enable-async-push. Your patch has been applied to the master branch. commit 7084a3993fa35c6fb71abe8aac7b30f442205e2a Author: Lev Stipakov Date:

[Openvpn-devel] [PATCH] systemd: Intermediate --chroot fix with the new sd_notify() implementation

Commit c5931897ae8d663e7e introduced support for talking directly to the systemd service manager about the situation for the OpenVPN tunnel. This approach makes a lot of sense and is mostly the proper way to do it. But it was discovered that it breaks OpenVPN configurations using --chroot. The re

[Openvpn-devel] [PATCH] Arm inotify only in server mode

Async-push is a server side feature and inotify_fd is initialized in server mode. Trac #786 --- src/openvpn/forward.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c index b50a2e0..4502e10 100644 --- a/src/openvpn/forward.c +++ b

Re: [Openvpn-devel] [PATCH applied] Fix wrong configure.ac parsing of --enable-async-push

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch This patch was slightly modified at commit time, changed from spaces to tabs on the line being modified. commit e62eccf025aa60ec268787d2aa4a46310ed1cd60 Author: David Sommerseth Date: Tue Dec 6 23:10

Re: [Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

Hi, On Tue, Dec 6, 2016 at 3:33 PM, Gert Doering wrote: > I'm going to merge your documentation patch now, for 2.4.0 and 2.3.14, > but for git master we should revisit this piece of , get rid of > "dhcp_masq_custom_offset" *and* make it default to 0 for both tun > and tap... (since there is no

Re: [Openvpn-devel] [PATCH] Fix wrong configure.ac parsing of --enable-async-push

ACK from me Tested with --disable-async-push, #define does not appear. 2016-12-07 0:10 GMT+02:00 David Sommerseth : > AC_ARG_ENABLE() was used wrong, which led enable_async_push to > always be set, regardless if --enable-async-push or --disable-async-push > was used. > > Also spotted the exact s

[Openvpn-devel] [PATCH] Fix wrong configure.ac parsing of --enable-async-push

AC_ARG_ENABLE() was used wrong, which led enable_async_push to always be set, regardless if --enable-async-push or --disable-async-push was used. Also spotted the exact same patch when writing this commit message as GitHub PR#70. Trac: #786 Signed-off-by: David Sommerseth --- configure.ac | 2 +

Re: [Openvpn-devel] fuzz testing by google ?

Hi, On Fri, Dec 02, 2016 at 08:48:29AM +0500, ?? wrote: > https://opensource.googleblog.com/2016/12/announcing-oss-fuzz-continuous-fuzzing.html This is generally interesting, of course. Fuzzing openvpn "as a whole" is quite complicated, though - we do check our input very we

Re: [Openvpn-devel] FreeBSD port versions (was: [PATCH applied] Re: Repair topology subnet on FreeBSD 11)

Hi, On Sat, Nov 12, 2016 at 05:43:56AM +0100, Matthias Andree wrote: > Am 11.11.2016 um 23:10 schrieb Gert Doering: > > I might be tempted to do a quick 2.3.14 release in between - there's two > > important platform fixes in that branch now (FreeBSD and OpenBSD topology > > subnet :-) ) and Lev's

[Openvpn-devel] [PATCH applied] Re: Correctly state the default dhcp server address in man page

ACK. Because it makes documentation match code. (This particular part of code needs to get some sanity, but this won't happen before 2.4.0) Your patch has been applied to the master and release/2.3 branch. commit 251cc8f2042cc0cb8281230f7fb33f2cdec5b809 (master) commit a1b9e4c1ac4ea1ebccf485ba2

Re: [Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

HI, On Fri, Dec 02, 2016 at 02:42:09PM -0500, Selva Nair wrote: > Also correct the default ifconfig-pool end in docs and comments > > Signed-off-by: Selva Nair > --- > doc/openvpn.8| 4 ++-- > src/openvpn/helper.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) "why oh why".

Re: [Openvpn-devel] [PATCH v3] Refactor setting close-on-exec for socket FDs

Am 06.12.16 um 13:26 schrieb Gert Doering: > The existing code can leak socket FDs to the "--up" script, which is > not desired. Brought up by Alberto Gonzalez Iniesta, based on debian > bug 367716. > > Since different sockets get create at different times, just moving the > set_cloexec() to link

[Openvpn-devel] [PATCH v3] Refactor setting close-on-exec for socket FDs

The existing code can leak socket FDs to the "--up" script, which is not desired. Brought up by Alberto Gonzalez Iniesta, based on debian bug 367716. Since different sockets get create at different times, just moving the set_cloexec() to link_socket_init_phase1() is not good enough - so move the

[Openvpn-devel] Topics for the upcoming (Wednesday, 7th Dec 2016) community meeting

Hi, We're going to have an IRC meeting on Wednesday 7th December 2016. The meeting begins at 20:00 CET (19:00 UTC) on #openvpn-meeting irc.freenode.net. You do not have to be logged in to Freenode to join the channel. Current topic list along with basic information is here:

Re: [Openvpn-devel] [PATCH] Refactor setting close-on-exec for socket FDs

On Mon, Dec 05, 2016 at 09:05:04PM +0100, Gert Doering wrote: > Hi, > > On Mon, Dec 05, 2016 at 08:01:14PM +0100, Alberto Gonzalez Iniesta wrote: > > The patch, after being adjusted to the new source, is not working anymore: > > > > Mon Dec 5 19:39:34 2016 Set FD_CLOEXEC flag on file descriptor