Re: [Openvpn-devel] [PATCH v2] Change the hold command to communicate the time that OpenVPN would wait to the UI.

2016-10-12 Thread Gert Doering
Hi, On Wed, Oct 12, 2016 at 10:46:02PM -0400, Selva Nair wrote: > Suggest to correct mechansim->mechanism (x2) in commit message during > merge. Will do. (Too busy today, tomorrow or weekend-ish) Thanks for the review. gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH v2] Check --ncp-ciphers list on startup

2016-10-12 Thread Selva Nair
On Wed, Oct 12, 2016 at 3:32 AM, Steffan Karger wrote: > Currently, if --ncp-ciphers contains an invalid cipher, OpenVPN will only > error out when that cipher is selected by negotiation. That's not very > friendly to the user, so check the list on startup, and give a clear error > message immed

Re: [Openvpn-devel] [PATCH v2] Change the hold command to communicate the time that OpenVPN would wait to the UI.

2016-10-12 Thread Selva Nair
Hi, On Wed, Oct 12, 2016 at 6:47 AM, Arne Schwabe wrote: > Before the connect-retry change to do exponential backup this was not > necessary > since the time was fixed. With the exponential backoff the UI needs either > to > implement its own exponential backoff mechansim or needs a way of knowi

Re: [Openvpn-devel] [Openvpn-users] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Selva Nair
Hi, On Wed, Oct 12, 2016 at 7:29 AM, Jose Alf. wrote: > I tested the 64 bit installer on Windows 7 Enterprise using default > settings. It ran smoothly. I notice that now there are 3 services - OpenVPN > Interactive Service (appears started automatic) > - OpenVPN Legacy Service (manual) > - Open

Re: [Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-12 Thread Jonathan K. Bullard
Thanks to both Gert and Arne for their answers. On Wed, Oct 12, 2016 at 9:12 AM, Arne Schwabe wrote: >> What I should have asked is: with this patch will an OpenVPN client >> still send out IPv4 packets if there are no IPv6 options specified or >> pulled from the server?

Re: [Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-12 Thread Arne Schwabe
> What I should have asked is: with this patch will an OpenVPN client > still send out IPv4 packets if there are no IPv6 options specified or > pulled from the server? In short: Behave exactly as before. Longer explaination: Without the patch OpenVPN refuses ifconfig-ipv6 and route-ipv6 without

Re: [Openvpn-devel] [Openvpn-users] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Samuli Seppänen
Hi Jose, Thanks for testing! The documentation about the new services is probably suboptimal right now. I will need to improve it a bit, because I believe what is said here is all we have right now. Quickly summarizing: 1) OpenVPNService (provided by o

Re: [Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-12 Thread Gert Doering
Hi, On Wed, Oct 12, 2016 at 08:53:02AM -0400, Jonathan K. Bullard wrote: > What I should have asked is: with this patch will an OpenVPN client > still send out IPv4 packets if there are no IPv6 options specified or > pulled from the server? Yes. Basically, the tun interface is now always in "du

Re: [Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-12 Thread Jonathan K. Bullard
Thanks, Arne. Sorry if I wasn't a clear as I should have been. On Wed, Oct 12, 2016 at 8:08 AM, Arne Schwabe wrote: > > Am 12.10.16 um 13:17 schrieb Jonathan K. Bullard: > > Hi. > > > > On Wed, Oct 12, 2016 at 5:13 AM, Arne Schwabe wrote: > >> This option was useful when Ipv6 tun support was > >

Re: [Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-12 Thread Arne Schwabe
Am 12.10.16 um 13:17 schrieb Jonathan K. Bullard: > Hi. > > On Wed, Oct 12, 2016 at 5:13 AM, Arne Schwabe wrote: >> This option was useful when Ipv6 tun support was >> non standard and was an internal/user specified flag >> that tracked the Ipv6 capability of the tun device. >> >> All supported

Re: [Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-12 Thread Jonathan K. Bullard
Hi. On Wed, Oct 12, 2016 at 5:13 AM, Arne Schwabe wrote: > > This option was useful when Ipv6 tun support was > non standard and was an internal/user specified flag > that tracked the Ipv6 capability of the tun device. > > All supported OS support IPv6. Also tun-ipv6 is > pushable by the remote s

Re: [Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Илья Шипицин
yes, https://github.com/OpenVPN/openvpn-gui/pull/45 2016-10-12 15:56 GMT+05:00 Samuli Seppänen : > Hi Ilya, > > Did you issue a PR with that fix? I don't see that commit in Git logs for > OpenVPN/OpenVPN-GUI on GitHub. > > -- > Samuli Seppänen > Community Manager > OpenVPN Technologies, Inc > > i

Re: [Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Samuli Seppänen
Il 12/10/2016 13:30, Ton van Vliet ha scritto: > On 11-10-16 12:36, Samuli Seppänen wrote: >> However, we'd need to help with testing these preview installers: > > 64 bit version on Win7 Home Premium installation process without issues. > > Observed a small issue when looking at the 'Settings...' o

Re: [Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Samuli Seppänen
Hi Ilya, Did you issue a PR with that fix? I don't see that commit in Git logs for OpenVPN/OpenVPN-GUI on GitHub. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock Il 12/10/2016 13:43, Илья Шипицин ha scritto: > it should have been fixed with > https://

[Openvpn-devel] [PATCH v2] Change the hold command to communicate the time that OpenVPN would wait to the UI.

2016-10-12 Thread Arne Schwabe
Before the connect-retry change to do exponential backup this was not necessary since the time was fixed. With the exponential backoff the UI needs either to implement its own exponential backoff mechansim or needs a way of knowing the value of OpenVPN internal mechansim. Patch V2: Fixed typos not

Re: [Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Илья Шипицин
it should have been fixed with https://github.com/OpenVPN/openvpn-gui/commit/727eaee0c54b0aee01ad28f622c1da7011e7b7c1 @mattock ? 2016-10-12 15:30 GMT+05:00 Ton van Vliet : > On 11-10-16 12:36, Samuli Seppänen wrote: > > However, we'd need to help with testing these preview installers: > > > 64 b

Re: [Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Ton van Vliet
On 11-10-16 12:36, Samuli Seppänen wrote: However, we'd need to help with testing these preview installers: 64 bit version on Win7 Home Premium installation process without issues. Observed a small issue when looking at the 'Settings...' of the new GUI: 1st tab: labeled 'Proxy' content in Eng

[Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-12 Thread Arne Schwabe
This option was useful when Ipv6 tun support was non standard and was an internal/user specified flag that tracked the Ipv6 capability of the tun device. All supported OS support IPv6. Also tun-ipv6 is pushable by the remote so not putting tun-ipv6 does not forbid ipv6 addresses. This commit al

[Openvpn-devel] [PATCH v2] Check --ncp-ciphers list on startup

2016-10-12 Thread Steffan Karger
Currently, if --ncp-ciphers contains an invalid cipher, OpenVPN will only error out when that cipher is selected by negotiation. That's not very friendly to the user, so check the list on startup, and give a clear error message immediately. This patches changes the cipher_kt_get() to let the call

Re: [Openvpn-devel] [PATCH] Check --ncp-ciphers list on startup

2016-10-12 Thread Steffan Karger
On 11 October 2016 at 22:11, Selva Nair wrote: > To nit-pick, Yes, please! > On Tue, Oct 11, 2016 at 3:35 PM, Steffan Karger wrote: >> >> +bool >> +tls_check_ncp_cipher_list(const char *list) { >> + char *tmp_ciphers = string_alloc (list, NULL); >> + char *tmp_ciphers_orig = tmp_ciphers; >> +