Re: [Openvpn-devel] [PATCH] Check --ncp-ciphers list on startup

2016-10-11 Thread Selva Nair
Hi, To nit-pick, On Tue, Oct 11, 2016 at 3:35 PM, Steffan Karger wrote: > +bool > +tls_check_ncp_cipher_list(const char *list) { > + char *tmp_ciphers = string_alloc (list, NULL); > + char *tmp_ciphers_orig = tmp_ciphers; > + bool unsupported_cipher_found = false; > + > + const char *token

[Openvpn-devel] [PATCH] Check --ncp-ciphers list on startup

2016-10-11 Thread Steffan Karger
Currently, if --ncp-ciphers contains an invalid cipher, OpenVPN will only error out when that cipher is selected by negotiation. That's not very friendly to the user, so check the list on startup, and give a clear error message immediately. This patches changes the cipher_kt_get() to let the call

Re: [Openvpn-devel] [PATCH applied] Use separate list for per-client push options

2016-10-11 Thread David Sommerseth
I sent this too quick. I just slightly modified the commit message (removing a duplicated sentence after the signed-off-by line). So the proper commitish is commit 88c4b9d6ad1d346931d9090b247e9e3d2d86bce7 On 11/10/16 14:12, David Sommerseth wrote: > > Your patch has been applied to the ma

Re: [Openvpn-devel] [PATCH applied] Use separate list for per-client push options

2016-10-11 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 9bc893d0d365be0bd2911d91a004be8b3739307b Author: Lev Stipakov Date: Tue Oct 11 11:03:50 2016 +0300 Use separate list for per-client push options Signed-off-by: Lev Stipakov

[Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-11 Thread Samuli Seppänen
Hi all, We're really close to OpenVPN 2.4-alpha1 release now. In yesterday's IRC meeting[1] we deemed that "late this week" might be doable. However, we'd need to help with testing these preview installers:

Re: [Openvpn-devel] [PATCH applied] systemd: Do not mask usernames when querying for it via systemd-ask-password

2016-10-11 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 8ba3e25897af5c7bd7b4f706961e9528d6988d83 Author: David Sommerseth Date: Thu Aug 11 16:33:55 2016 +0200 systemd: Do not mask usernames when querying for it via systemd-ask-password

Re: [Openvpn-devel] [PATCH applied] Re-implement the systemd support using the new query user API

2016-10-11 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 3280d8c8f3583d03fed923837447ef45c8f83d52 Author: David Sommerseth Date: Fri Aug 12 12:57:25 2016 +0200 Re-implement the systemd support using the new query user API Signed-off-by:

Re: [Openvpn-devel] [PATCH applied] Rework the user input interface to make it more modular

2016-10-11 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 430ce8bd03b23717ec42a8a34aa66e804ca97287 Author: David Sommerseth Date: Fri Aug 26 19:48:52 2016 +0200 Rework the user input interface to make it more modular Signed-off-by: David

Re: [Openvpn-devel] (no subject)

2016-10-11 Thread David Sommerseth
On 11/10/16 04:15, Leon Tanoh wrote: > 172.29.29.1 host not found. -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _

[Openvpn-devel] [PATCH v4] Use separate list for per-client push options

2016-10-11 Thread Lev Stipakov
v4: - fix whitespaces, wrap long lines v3: - rebase on master v2: - Also move ifconfig and ipv6-ifconfig to separate options list Move client-specific push options (currently peer-id and cipher) to separate list, which is deallocated after push_reply has been send. This makes sure that option