Re: [Openvpn-devel] [PATCH v4 1/4] Rework the user input interface to make it more modular

Hi, On Mon, Aug 8, 2016 at 3:28 PM, David Sommerseth wrote: > This is will provide an interface for other mechanisms to be used to > query the user for information, such as usernames, passwords, etc. > > It has also been a goal to make it possible to query for all the > information in one call a

Re: [Openvpn-devel] [PATCH applied] Re: Avoid format specifier %zu for Windows compatibility

Hi, On 12/08/16 16:27, David Sommerseth wrote: > Your patch has been applied to the master branch. > > commit fff2b444ae8344c063ff819074a355e0a5aa47df > Author: Selva Nair > Date: Thu Aug 11 18:58:29 2016 -0400 > > Avoid format specifier %zu for Windows compatibility > > Signed-off-

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

On Fri, 2016-08-12 at 23:02 +0200, Gert Doering wrote: > This is a good argument.  Unfortunately, it's a surprisingly *hairy* one, > as there are time zones that do not have a full-hour offset - so ISO 8601 > (according to wikipedia) says you should do "±hh:mm" then - and for > most folks, ":mm" wo

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

Hi, On Fri, Aug 12, 2016 at 09:53:34PM +0200, David Woodhouse wrote: > On Thu, 2016-08-11 at 21:23 +0200, Gert Doering wrote: > > All our timestams used to be "what ctime()" produces, which is > > > >   "Thu Aug 11 21:15:27 2016" > > > > Changed to use POSIX standard format, which is > > > >  

Re: [Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

Hi, On Fri, Aug 12, 2016 at 03:32:57PM -0400, Selva Nair wrote: > Thanks for the clarification. AFAIK, we do not parse status output in > OpenVPN GUI. Good :-) > A UI for server would need to parse those and it would have > been nicer to have status timestamps sent to management be in unix time

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

On Thu, 2016-08-11 at 21:23 +0200, Gert Doering wrote: > All our timestams used to be "what ctime()" produces, which is > >   "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > >   "2016-08-11 21:15:27" While you're at it, perhaps also add the timezone in numeric (±

Re: [Openvpn-devel] autoconf/automake warnings

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/16 21:40, Selva Nair wrote: > > When that happens we add a version check to define subdir_objects > = "subdir-objects" and add that as we do for serial-objects. Its a > bit premature to do that until next version of automake is out. Aha! Tha

Re: [Openvpn-devel] autoconf/automake warnings

On Fri, Aug 12, 2016 at 2:38 PM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > > I would say ignore the subdir-objects warning for now and we can > > conditionally enable it when a version of automake that supports > > it without breaking use of variables in foo_SOURCES becomes wi

Re: [Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

On Fri, Aug 12, 2016 at 2:45 PM, Gert Doering wrote: > > On Fri, Aug 12, 2016 at 02:25:54PM -0400, Selva Nair wrote: > > > +- all time stamps, including log file, status file and management > > > interface, > > > + are now output in ISO 8601 standard format. > > > + > > > > Currently the >LOG me

Re: [Openvpn-devel] [PATCH] Fix warning appearing in newer autoconf/libtool version

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/16 21:13, Gert Doering wrote: > Hi, > > On Fri, Aug 12, 2016 at 08:54:47PM +0200, David Sommerseth wrote: >> The warning which appears with autoconf-2.69 with libtool-2.4.2 >> is: >> >> libtoolize: Remember to add 'LT_INIT' to configure.ac.

Re: [Openvpn-devel] [PATCH] Fix warning appearing in newer autoconf/libtool version

Hi, On Fri, Aug 12, 2016 at 08:54:47PM +0200, David Sommerseth wrote: > The warning which appears with autoconf-2.69 with libtool-2.4.2 is: > >libtoolize: Remember to add 'LT_INIT' to configure.ac. > > Signed-off-by: David Sommerseth > --- > configure.ac | 1 + > 1 file changed, 1 insertio

[Openvpn-devel] [PATCH] Fix warning appearing in newer autoconf/libtool version

The warning which appears with autoconf-2.69 with libtool-2.4.2 is: libtoolize: Remember to add 'LT_INIT' to configure.ac. Signed-off-by: David Sommerseth --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 4f14ebd..69fdd99 100644 --- a/conf

Re: [Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

Hi, On Fri, Aug 12, 2016 at 02:25:54PM -0400, Selva Nair wrote: > > +- all time stamps, including log file, status file and management > > interface, > > + are now output in ISO 8601 standard format. > > + > > Currently the >LOG message to the management is like > > >LOG:1471025385,,Closing TUN

Re: [Openvpn-devel] autoconf/automake warnings

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/16 20:27, Selva Nair wrote: > > On Fri, Aug 12, 2016 at 6:30 AM, David Sommerseth > > wrote: > > On 12/08/16 03:14, Selva Nair wrote: >> >> >> On Thu, Aug 11, 2016 at 2:50 PM, David Sommerseth >

Re: [Openvpn-devel] autoconf/automake warnings

On Fri, Aug 12, 2016 at 6:30 AM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > On 12/08/16 03:14, Selva Nair wrote: > > > > > > On Thu, Aug 11, 2016 at 2:50 PM, David Sommerseth > > > > wrote: > > > > -BEGIN PGP SIGNED MESSAGE- Ha

Re: [Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

On Fri, Aug 12, 2016 at 1:41 PM, Gert Doering wrote: > diff --git a/Changes.rst b/Changes.rst > index 9fcba75..ad6363e 100644 > --- a/Changes.rst > +++ b/Changes.rst > @@ -135,6 +135,9 @@ User-visible Changes >ciphers configured in the config file. Use --ncp-disable if you don't > want >

Re: [Openvpn-devel] [PATCH v2] Drop recursively routed packets

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/01/16 13:43, Lev Stipakov wrote: > v2: better method naming > > On certain OSes (Windows, OS X) when network adapter is disabled > (ethernet cable pulled off, Wi-Fi hardware switch disabled), > operating system starts to use tun as an external

Re: [Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

Am 12.08.16 um 19:41 schrieb Gert Doering: > All our timestams used to be "what ctime()" produces, which is > > "Thu Aug 11 21:15:27 2016" > > Changed to use ISO 8601 standard format, which is > > "2016-08-11 21:15:27" > > this applies to logging (except to syslog or if --machine-readable-o

[Openvpn-devel] [PATCH v4.1 2/4] Re-implement the systemd support using the new query user API

This provides exactly the same systemd functionality which existed before the query user infrastructure got implemented. [v5 - Ensure NULL termination fix in d09fbf958f1c is included ] [v4 - change disapproved &= syntax ] [v3 - Remove QUERY_USER_EXEC_ALTERNATIVE macro, simplify alt

[Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

All our timestams used to be "what ctime()" produces, which is "Thu Aug 11 21:15:27 2016" Changed to use ISO 8601 standard format, which is "2016-08-11 21:15:27" this applies to logging (except to syslog or if --machine-readable-ouput is used) and to various other places where informational

Re: [Openvpn-devel] autoconf/automake warnings

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/16 03:14, Selva Nair wrote: > > > On Thu, Aug 11, 2016 at 2:50 PM, David Sommerseth > > wrote: > > -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > > > Hi, > > I noticed a few errors today when

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/08/16 21:23, Gert Doering wrote: > All our timestams used to be "what ctime()" produces, which is > > "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > > "2016-08-11 21:15:27" > > this applies to logging (except

Re: [Openvpn-devel] autoconf/automake warnings

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/08/16 22:44, Selva Nair wrote: > Hi, > > You are right, it was me who introduced reference to sources in > subdir to avoid duplication when block-dns support was added to the > interactive service. > > On Thu, Aug 11, 2016 at 2:50 PM, David Som

Re: [Openvpn-devel] [PATCH v4 2/4] Re-implement the systemd support using the new query user API

On 12/08/16 06:11, Selva Nair wrote: > (sending again with the list in CC:) > > Mon, Aug 8, 2016 at 3:28 PM, David Sommerseth > wrote: > > This provides exactly the same systemd functionality which existed > before the query user infrastructure got implemented.

[Openvpn-devel] [PATCH applied] Re: Avoid format specifier %zu for Windows compatibility

Your patch has been applied to the master branch. commit fff2b444ae8344c063ff819074a355e0a5aa47df Author: Selva Nair Date: Thu Aug 11 18:58:29 2016 -0400 Avoid format specifier %zu for Windows compatibility Signed-off-by: Selva Nair Acked-by: David Sommerseth Message-Id:

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/16 00:58, Selva Nair wrote: > - Replace %zu by %u and cast the size_t variable to (unsigned int). > The cast should be safe as in all instances the number involved is > small. > > Note: mingw64 targets msvcrt.dll runtime that doesn't support

[Openvpn-devel] [PATCH v4 2/4] Re-implement the systemd support using the new query user API

(sending again with the list in CC:) Mon, Aug 8, 2016 at 3:28 PM, David Sommerseth wrote: > This provides exactly the same systemd functionality which existed > before the query user infrastructure got implemented. > > [v4 - change disapproved &= syntax ] > > [v3 - Remove QUERY_USER_EXEC_ALT

Re: [Openvpn-devel] [PATCH v4.1] systemd: Do not mask usernames when querying for it via systemd-ask-password

On Thu, Aug 11, 2016 at 10:33 AM, David Sommerseth wrote: > In systemd after version 216, systemd-ask-password will support --echo > which > will avoid masking the user input. As OpenVPN uses this mechanism > collecting > usernames when systemd is available, this will avoid the input of > userna

Re: [Openvpn-devel] autoconf/automake warnings

On Thu, Aug 11, 2016 at 2:50 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Hi, > > I noticed a few errors today when building OpenVPN on Fedora 23. The > attached patch resolves this. But it breaks 'make' when it reaches > ./src/openvpnserv: > The patch is