[Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Selva Nair
- Replace %zu by %u and cast the size_t variable to (unsigned int). The cast should be safe as in all instances the number involved is small. Note: mingw64 targets msvcrt.dll runtime that doesn't support %zu and print "zu" instead of the number. With -Wformat the compiler does warn t

Re: [Openvpn-devel] autoconf/automake warnings

2016-08-11 Thread Selva Nair
Hi, You are right, it was me who introduced reference to sources in subdir to avoid duplication when block-dns support was added to the interactive service. On Thu, Aug 11, 2016 at 2:50 PM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > Hi, > > I noticed a few errors today when b

[Openvpn-devel] Status of the VLAN patches review?

2016-08-11 Thread Mike Auty
Hi there, I was hoping to find out if there'd been any progress on getting the VLAN patches reviewed? Thanks, Mike 5:) [1] https://sourceforge.net/p/openvpn/mailman/message/3496/ [2] https://github.com/ikelos/openvpn

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-11 Thread Илья Шипицин
iso 8601 is good format. it is accepted by default by sql servers, Log Parser 2016-08-12 0:23 GMT+05:00 Gert Doering : > All our timestams used to be "what ctime()" produces, which is > > "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > > "2016-08-11 21:15:27"

[Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-11 Thread Gert Doering
All our timestams used to be "what ctime()" produces, which is "Thu Aug 11 21:15:27 2016" Changed to use POSIX standard format, which is "2016-08-11 21:15:27" this applies to logging (except to syslog or if --machine-readable-ouput is used) and to various other places where informational ti

Re: [Openvpn-devel] autoconf/automake warnings

2016-08-11 Thread Gert Doering
hi, On Thu, Aug 11, 2016 at 08:50:22PM +0200, David Sommerseth wrote: > I noticed a few errors today when building OpenVPN on Fedora 23. The > attached patch resolves this. But it breaks 'make' when it reaches > ./src/openvpnserv: > > Makefile:505: ../../src/openvpn/.deps/openvpnserv-block_dns.

[Openvpn-devel] autoconf/automake warnings

2016-08-11 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I noticed a few errors today when building OpenVPN on Fedora 23. The attached patch resolves this. But it breaks 'make' when it reaches ./src/openvpnserv: Makefile:505: ../../src/openvpn/.deps/openvpnserv-block_dns.Po: No such file or director

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Selva Nair
On Thu, Aug 11, 2016 at 1:30 PM, Gert Doering wrote: > sorry for being a bit lazy in answering. This is the sort of threads > that lead to endless wars ... :-) > Oh, no, this one is not worth even a fist fight, forget wars :) > > On Sun, Aug 07, 2016 at 10:47:16AM -0400, Selva Nair wrote: > >

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Gert Doering
Hi, sorry for being a bit lazy in answering. This is the sort of threads that lead to endless wars ... :-) On Sun, Aug 07, 2016 at 10:47:16AM -0400, Selva Nair wrote: > > I looked into this a bit, and it should indeed fix the printing of %zu > > on Windows. I would prefer to teach autotools to

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Selva Nair
On Sun, Aug 7, 2016 at 10:47 AM, Selva Nair wrote: > Hi, > > On Sun, Aug 7, 2016 at 10:04 AM, Steffan Karger wrote: > >> On 5 August 2016 at 15:09, Selva Nair wrote: >> > On Fri, Aug 5, 2016 at 3:32 AM, Steffan Karger >> wrote: >> >> On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering >> wrote: >> >

Re: [Openvpn-devel] [PATCH] Added client-ip option to NAT

2016-08-11 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/07/16 13:53, Rafael Gava wrote: [...snip...] > Your request not to use 'localhost' is ok. So I changed > 'client-ip'. But since we have so many clients already configured > with the 'localhost' keyword, we would like to gradually make the > tran

[Openvpn-devel] [PATCH v4.1] systemd: Do not mask usernames when querying for it via systemd-ask-password

2016-08-11 Thread David Sommerseth
In systemd after version 216, systemd-ask-password will support --echo which will avoid masking the user input. As OpenVPN uses this mechanism collecting usernames when systemd is available, this will avoid the input of usernames to be masked. This patch also adds the --icon argument, which is ai

Re: [Openvpn-devel] [PATCH v4 3/4] autotools: Add support for extracting version information from pkg-config modules

2016-08-11 Thread David Sommerseth
On 11/08/16 08:45, Selva Nair wrote: > Hi, > > I missed this patch -- must have deleted from the inbox by mistake. So > that explains my silly comment about pkg.m4 in a previous mail. > :) [...snip...] > PKG_CHECK_EXISTS( [libsystemd > 216], > [AC_DEFINE([SYSTEMD_ASKPASS_H

Re: [Openvpn-devel] [PATCH v4 3/4] autotools: Add support for extracting version information from pkg-config modules

2016-08-11 Thread Selva Nair
Hi, I missed this patch -- must have deleted from the inbox by mistake. So that explains my silly comment about pkg.m4 in a previous mail. On Mon, Aug 8, 2016 at 3:28 PM, David Sommerseth wrote: > This patch adds extracting the pkg-config --modversion output into a > variable configure.ac can c