Re: [Openvpn-devel] [PATCH 2/2] Add a test for auth-pam searchandreplace

2016-05-26 Thread Steffan Karger
Hi, Sorry for not noticing before, but one last nit: On Wed, May 25, 2016 at 7:57 PM, wrote: > +/* Read 'tosearch', replace all occurences of 'searchfor' with > 'replacewith' and return > + * a pointer to the NEW string. Does not modify the input strings. Will > not enter an > + * infini

Re: [Openvpn-devel] [PATCH 1/2] Add unit testing support via cmocka

2016-05-26 Thread Steffan Karger
On Wed, May 25, 2016 at 7:57 PM, wrote: > From: Jens Neuhalfen > > cmocka [1,2] is a testing framework for C. Adding unit test capabilities to > the > openvpn repository will greatly ease the task of writing correct code. > > cmocka source code is added as git submodule in ./vendor. A submodule

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-26 Thread Samuli Seppänen
... The buildmaster part is not documented anywhere. I have shared the master config once when someone requested it - there is nothing inherently private in there, once the passwords are removed. Setting up buildmaster + buildslaves could definitely be automated, but it would be a rather

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-26 Thread Samuli Seppänen
... The buildmaster part is not documented anywhere. I have shared the master config once when someone requested it - there is nothing inherently private in there, once the passwords are removed. Setting up buildmaster + buildslaves could definitely be automated, but it would be a rather m