[Openvpn-devel] [PATCH 1/2] Add unit testing support via cmocka

2016-05-25 Thread openvpn-devel
From: Jens Neuhalfen cmocka [1,2] is a testing framework for C. Adding unit test capabilities to the openvpn repository will greatly ease the task of writing correct code. cmocka source code is added as git submodule in ./vendor. A submodule approach has been chosen over a classical library depe

[Openvpn-devel] [PATCH 2/2] Add a test for auth-pam searchandreplace

2016-05-25 Thread openvpn-devel
From: Jens Neuhalfen No functional changes. Utility functions of auth-pam are split into a dedicated file. This allows the test programs to easily test these functions without adding dependencies. Add a minimal test for searchandreplace as a proof of concept. Signed-off-by: Jens Neuhalfen ---

[Openvpn-devel] Add unit testing support

2016-05-25 Thread openvpn-devel
This is a series of two patches that add unit testing support to openvpn. See https://github.com/OpenVPN/openvpn/pull/44 for a discussion. Thanks to syzzer for his nitty-gritty review! Jens

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread David Sommerseth
On 25/05/16 17:27, Selva Nair wrote: > > Well, if a major rewrite of console input is planned, consider > replacing getpass() as well. It has arbitrary password length > limitations on some platforms. At the same time I'm not sure I > understand the need for this overhaul. Currently the interface

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-25 Thread Jens Neuhalfen
... > > The buildmaster part is not documented anywhere. I have shared the master > config once when someone requested it - there is nothing inherently private > in there, once the passwords are removed. Setting up buildmaster + > buildslaves could definitely be automated, but it would be a ra

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread Selva Nair
On Tue, May 24, 2016 at 6:53 PM, Selva Nair wrote: > Do not mask input when echo is requested. Useful for username > input and sometimes for challenge response. > > Signed-off-by: Selva Nair Patch withdrawn in deference to David's pending patches that address this among other things.. Also thi

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread Selva Nair
Hi David, On Wed, May 25, 2016 at 12:17 PM, David Sommerseth wrote: > On 25/05/16 17:27, Selva Nair wrote: > > > > Well, if a major rewrite of console input is planned, consider > > replacing getpass() as well. It has arbitrary password length > > limitations on some platforms. At the same time

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread Selva Nair
On Wed, May 25, 2016 at 6:12 AM, David Sommerseth wrote: > On 25/05/16 00:53, Selva Nair wrote: > > Do not mask input when echo is requested. Useful for username > > input and sometimes for challenge response. > > > > Signed-off-by: Selva Nair > > .. > > Hi Selva, > > Thanks a lot! This patch d

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread David Sommerseth
On 25/05/16 00:53, Selva Nair wrote: > Do not mask input when echo is requested. Useful for username > input and sometimes for challenge response. > > Signed-off-by: Selva Nair > --- > src/openvpn/console.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/open

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-25 Thread Samuli Seppänen
Hi, On Mon, May 23, 2016 at 05:43:58PM +0200, Jens Neuhalfen wrote: I'd prefer to keep the actual buildslave infrastructure private, with access granted to only a select few. We already get email notifications to a public list for each build failure. Is there some kind of instruction to ?r