ACK, thanks.
Your patch has been applied to the master branch.
commit 600dd9a16fc61ff6e595f500fba5daf14248b739
Author: Selva Nair
List-Post: openvpn-devel@lists.sourceforge.net
Date: Sun May 22 14:39:32 2016 -0400
Fix handling of out of memory error in interactive service
Signed-off
Currently realloc failure in UpdateWaitHandles() is handled by
triggering exit_event and waiting for all active worker threads
to terminate. However, at this point the wait handles array
will contain an invalid value (handle of the latest thread that
is terminated), causing a cycle of WAIT_FAILED <
On Sun, May 22, 2016 at 12:56 PM, Gert Doering wrote:
> Mmmh, anyway, I have two options now :-) - ask you for a v2 that is
> MSVC 2010 compatible, and has the initial value reverted to "10", or
> just apply...
>
Let's make life easy -- will do a v2 with both those changes:-) and just
hope if/wh
Hi,
On Sun, May 22, 2016 at 11:00:22AM -0400, Selva Nair wrote:
> > On Sun, May 22, 2016 at 12:46:27AM -0400, Selva Nair wrote:
> > > {
> > >size += 10;
> > > - handles = realloc (handles, size * sizeof (HANDLE));
> > > - if (handles == NULL)
> > > -
copy to the list...
On Sun, May 22, 2016 at 3:31 AM, Gert Doering wrote:
> Hi,
>
> On Sun, May 22, 2016 at 12:46:27AM -0400, Selva Nair wrote:
> > {
> >size += 10;
> > - handles = realloc (handles, size * sizeof (HANDLE));
> > - if (handles == NULL)
> > -
Hi,
Thanks for the comments.
On Sun, May 22, 2016 at 3:26 AM, Gert Doering wrote:
> thanks for digging into this. Overall, the patch makes sense, I'm just
> wondering about this:
>
> On Sun, May 22, 2016 at 12:46:27AM -0400, Selva Nair wrote:
> > Other changes:
> > - Use minimal initial alloca
Hi,
On Sun, May 22, 2016 at 02:38:05PM +0200, Jens Neuhalfen wrote:
> [???]
>
> > My buildbots test on "all the BSDs" (Free, Net, Open, and they have a
> > /bin/sh which is "It only supports features designated by POSIX plus a few
> > Berkeley extensions") and OpenSolaris 11 (ksh93). Samuli's b
Gert, Samuli
[…]
>
> My buildbots test on "all the BSDs" (Free, Net, Open, and they have a
> /bin/sh which is "It only supports features designated by POSIX plus a few
> Berkeley extensions") and OpenSolaris 11 (ksh93). Samuli's buildbot
> test on various Linux variants, so "dash" should work.
Hi,
On Sun, May 22, 2016 at 10:44:41AM +0200, Jens Neuhalfen wrote:
> A broken ssl library and openvpn - What could possibly go wrong?
We could recommend building with mbedtls... :-)
gert
--
USENET is *not* the non-clickable part of WWW!
Hi Gert,
openssl is a joy to work with :-/
[snip]
> Ceterum censeo: I acknowledge that something is funny here, but I do not
> think it's OpenVPN's fault (otherwise it should show up for me), so not
> much we can do about it.
A broken ssl library and openvpn - What could possibly go wrong?
B
Hi,
On Sat, May 21, 2016 at 11:32:40PM +0200, Jens Neuhalfen wrote:
> This is
> * Solaris 11.3 on Intel 64 bit (isainfo -k ???> amd64), fresh from
> Sun^H^H^HOracle
>
> * OpenSSL 1.0.1p. openssl is compiled as 32 bit library (file
> /lib/libcrypto.so.1.0.0 ???> /lib/libcrypto.so.1.0.0:
Hi,
On Sun, May 22, 2016 at 12:46:27AM -0400, Selva Nair wrote:
> {
>size += 10;
> - handles = realloc (handles, size * sizeof (HANDLE));
> - if (handles == NULL)
> -return ERROR_OUTOFMEMORY;
> + LPHANDLE tmp = realloc (handles, size * si
Hi,
thanks for digging into this. Overall, the patch makes sense, I'm just
wondering about this:
On Sun, May 22, 2016 at 12:46:27AM -0400, Selva Nair wrote:
> Other changes:
> - Use minimal initial allocation size so that the realloc code path
> gets exercised (2 or more connections will cause
Currently realloc failure in UpdateWaitHandles() is handled by
triggering exit_event and waiting for all active worker threads
to terminate. However, at this point the wait handles array
will contain an invalid value (handle of the latest thread that
is terminated), causing a cycle of WAIT_FAILED <
On Sat, May 14, 2016 at 8:31 AM, Selva Nair wrote:
> On Fri, May 13, 2016 at 11:12 PM, Selva Nair wrote:
>
>> ---
>> src/openvpnserv/interactive.c | 10 +++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>
>
> Please ignore this patch. It is broken -- patch made prematurely befo
15 matches
Mail list logo
