Re: [Openvpn-devel] [PATCH applied] Re: Fix polarssl / mbedtls builds

2016-05-13 Thread Matthias Andree
Am 13.05.2016 um 09:32 schrieb Gert Doering: > ACK. Tested on FreeBSD 9.3, all 3 tests in "make check", works. > > It is in line with the much better tested code in master, and with the > man page: > > "The default for --tls-cipher is to use PolarSSL's default cipher > list when using PolarS

Re: [Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread Selva Nair
Hi, On Fri, May 13, 2016 at 5:55 AM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > On 13/05/16 04:40, Selva Nair wrote: > > Fixes Trac #71 (see comments 37 to 43) > > Nit pick on the commit message. Thanks for responding to the patch. > This message isn't really helpful. And

Re: [Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread debbie10t
On 13/05/16 10:55, David Sommerseth wrote: I can recommend this blog post on this topic: Thanks David .. Excellent link ! Took me to this: http://git-scm.com/book I wonder if you could recommend a comparable "book on C" ? Cheerz

[Openvpn-devel] [PATCH] Add CHACHA20-POLY1305 ciphersuite IANA name translations.

2016-05-13 Thread Dorian Harmans
--- src/openvpn/ssl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index ddd0c9b..4291314 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -146,6 +146,7 @@ static const tls_cipher_name_pair tls_cipher_name_translation_table[] = { {"DHE

Re: [Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread David Sommerseth
On 13/05/16 04:40, Selva Nair wrote: > Fixes Trac #71 (see comments 37 to 43) Nit pick on the commit message. This message isn't really helpful. And it presumes that Trac will be available "forever". We should always ensure commit messages do not purely depend on external resources. I can reco

[Openvpn-devel] [PATCH applied] Re: Fix polarssl / mbedtls builds

2016-05-13 Thread Gert Doering
ACK. Tested on FreeBSD 9.3, all 3 tests in "make check", works. It is in line with the much better tested code in master, and with the man page: "The default for --tls-cipher is to use PolarSSL's default cipher list when using PolarSSL or (...) when using OpenSSL" Your patch has been applie

Re: [Openvpn-devel] SIGSEGV (NULL ptr deref) in PolarSSL-based build if noTLS ciphers specified (was: OpenVPN 2.3.11 released)

2016-05-13 Thread Gert Doering
Hi, On Fri, May 13, 2016 at 01:12:05AM +0200, Matthias Andree wrote: > Unfortunately, it appears that at least with PolarSSL 1.3.16, this > release introduces a crasher regression which easily shows up in a "make > check" on FreeBSD when no specific ciphers are selected. Backtrace > below. The O

[Openvpn-devel] [PATCH] Fix polarssl / mbedtls builds

2016-05-13 Thread Steffan Karger
Commit 8a399cd3 hardened the OpenSSL default cipher list, but also introduced a change in shared code that causes polarssl / mbedtls builds to break when no --tls-cipher is specified. This fix is backported code from the master branch. Signed-off-by: Steffan Karger --- src/openvpn/ssl_polarssl.

[Openvpn-devel] [PATCH master] Make error non-fatal while deleting address using netsh

2016-05-13 Thread Selva Nair
Fixes Trac #71 (see comments 37 to 43) Signed-off-by: Selva Nair --- src/openvpn/tun.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index c87fb36..f79d067 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -

[Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread Selva Nair
Fixes Trac #71 (see comments 37 to 43) Signed-off-by: Selva Nair --- src/openvpn/tun.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index b70410d..11027dd 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -