On Wed, Apr 27, 2016 at 1:00 PM, Arne Schwabe wrote:
> Am 17.04.16 um 21:35 schrieb Steffan Karger:
>> #ifdef HAVE_AEAD_CIPHER_MODES
>
> Are there actually mBedTLS >=2.0 without this?
It's possible to compile mbed TLS without GCM, yes. Though I could
imagine getting rid of HAVE_AEAD_CIPHER_MOD
On Wed, Apr 27, 2016 at 7:51 PM, Gert Doering wrote:
> While I totally love to just merge stuff other folks have reviewed, this
> patch just doesn't apply to my tree :-( - and the rejects are too many
> to try to mangle by hand.
>
> Patching file configure.ac using Plan A...
> Hunk #1 failed at 29
Hi,
I put together a set of patches that add unit testing support for openvpn. To
make comments easier I put them together as pull request on github.
Please review the patch and point out points of improvement. After that I will
post the “real” patches to the list.
https://github.com/OpenVPN/o
Your patch has been applied to the master branch.
commit 4e37af92f5729cc29e5abdc873bac529c5a42ef9
Author: Lev Stipakov
List-Post: openvpn-devel@lists.sourceforge.net
Date: Wed Nov 11 15:00:49 2015 +0200
Fix "implicit declaration" compiler warning
Signed-off-by: Lev Stipakov
Ac
Hi,
On Wed, Apr 27, 2016 at 01:21:41PM +0300, Arne Schwabe wrote:
> Am 04.01.16 um 20:22 schrieb sam...@openvpn.net:
> > From: Samuli Seppänen
> >
> > OpenVPN 2.3.10 includes an OpenVPN-GUI which automatically requests
> > elevation of
> > privileges using UAC. Modified INSTALL-win32.txt to ref
ACK!
Your patch has been applied to the master branch.
Sorry for ACKing the patch that broke the code - ACKing the fix now :-)
(I've taken the liberty to make the commit message more readable - no
code changes)
commit 13a882ae39efb7144d9a9c5ac61100b1e27b1003
Author: Daniel Kubec
List-Post: openv
Hi,
On Wed, Apr 27, 2016 at 02:00:47PM +0300, Arne Schwabe wrote:
> The rest looks fine, so ACK for me.
While I totally love to just merge stuff other folks have reviewed, this
patch just doesn't apply to my tree :-( - and the rejects are too many
to try to mangle by hand.
Patching file configur
Am 17.04.16 um 21:35 schrieb Steffan Karger:
> The patch looks huge, but it's just file renames, and required changes in
> includes / Makefiles. Use 'git diff -C' or a tool like gitk to easily
> review this patch.
ACK.
Arne
Am 17.04.16 um 21:35 schrieb Steffan Karger:
> #ifdef HAVE_AEAD_CIPHER_MODES
Are there actually mBedTLS >=2.0 without this?
The rest looks fine, so ACK for me.
Arne
P.S.: This was probably one of the most boring reviews I did (for most
part of the changes).
Am 17.04.16 um 21:35 schrieb Steffan Karger:
> #ifdef HAVE_AEAD_CIPHER_MODES
Are there actually mbedTLS version >= 2 without AEAD?
Arne
Am 04.01.16 um 20:22 schrieb sam...@openvpn.net:
> From: Samuli Seppänen
>
> OpenVPN 2.3.10 includes an OpenVPN-GUI which automatically requests elevation
> of
> privileges using UAC. Modified INSTALL-win32.txt to reflect this behavior.
>
ACK from me. This seems to be still not applied.
Arne
Yep, was a bit busy with other stuff last weeks.
On 27.04.2016 11:16, Arne Schwabe wrote:
I am just going through the patches. Lev, do you plan a follow up for this?
Arne
Am 11.11.15 um 15:00 schrieb Lev Stipakov:
> Add missing "include" directive.
>
> Signed-off-by: Lev Stipakov
> ---
> src/openvpn/mtcp.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c
> index b27c5eb..9926d47 100644
> --- a/src/openvpn/mtcp.
>
> + if (network && !strcmp(network, "client-ip"))
> +{
> + msg (M_INFO, "*** client-nat client-ip detected...");
> + e.network = 0x;
> +} else {
I am not sure that this message is useful. It does not provide any
additional information to the user. Also please add a
Am 09.10.15 um 16:39 schrieb Gert Doering:
> Hi,
>
> On Fri, Oct 09, 2015 at 03:29:17PM +0300, Lev Stipakov wrote:
>> + peer_id_disabled = peer_id == 0xFF;
>
> The general patch is fine, but while this line is technical correct, I don't
> think we should do so... please add least add so
Am 18.08.14 um 13:51 schrieb Josh Cepek:
> Correctly handle CIDR masks when pushing clients addressing from an IPv6
> pool. This change ignores the incorrectly used `bits` argument to the
> --ifconfig-ipv6-pool option.
>
> The code to save any provided CIDR mask after the pool IP is left in;
> thi
There is patch 'git show 41e4b67a229e774ebc57a882c386e10d80e10e7e'
which actually works arround poor support of c99 in MSVC compiler released
in 2013 :)
It introduces the bug because exported key size is always sizeof(unsigned
char *).
There is patch for this.>From 65c273f4d2eb63a26d270b870e303d5
17 matches
Mail list logo
