Re: [Openvpn-devel] [PATCH v3] interactive service v3

2016-02-05 Thread Gert Doering
Hi, On Wed, Jan 27, 2016 at 05:34:57PM +0800, Daniel Sim wrote: > Unless there are undiscovered vulnerabilities in the .NET framework itself, > >1. It is necessary to move away from pure C programs for Windows. >Microsoft's documentation for the services API apart from the .NET >frame

Re: [Openvpn-devel] [PATCH v3] interactive service v3

2016-02-05 Thread Gert Doering
Hi, On Thu, Feb 04, 2016 at 10:40:35AM -0500, Selva Nair wrote: > > (And yes, this needs to be adjusted in the installer, whichever way we > > go - globally writeable log directory, or user-individual logging) > > Its the "HKLM\OpenVPN\log_dir" key set by the installer when the service is > insta

[Openvpn-devel] [PATCH applied] Re: interactive service v3

2016-02-05 Thread Gert Doering
Your patch has been applied to the master branch. I have taken out the "AM_PROG_CC_C_O" change to configure.ac as the autoconf docs tell me that AC_PROG_CC will automatically check what this used to do, starting with 1.14 - and *that* one seems to be auto-invoked as well... (and I do not see us

[Openvpn-devel] [PATCH applied] Re: Fix undefined signed shift overflow

2016-02-05 Thread Gert Doering
ACK, thanks for sending it to the list. Your patch has been applied to the master and release/2.3 branch (manually applying to release/2.3 as the code there has three copies of the offending IPv4 code, and the IPv6 code isn't there yet...) Tested on FreeBSD 10.1 ("openvpn --show-gateway") commit

Re: [Openvpn-devel] [PATCH v3] interactive service v3

2016-02-05 Thread Gert Doering
Hi, On Fri, Feb 05, 2016 at 01:44:38PM +0800, Daniel Sim wrote: > May I ask a more generic question about the implementation of the > interactive service? > > So I understand that the patch allows clients to instruct the service to > modify the routing table. Yes and no. It allows clients to i

Re: [Openvpn-devel] [PATCH v3] interactive service v3

2016-02-05 Thread Daniel Sim
May I ask a more generic question about the implementation of the interactive service? So I understand that the patch allows clients to instruct the service to modify the routing table. In short, it allows ordinary users (since any program could impersonate the openvpn client) to modify the routin

Re: [Openvpn-devel] Test installers with the Interactive service / Vista-compatible block-outside-dns

2016-02-05 Thread Selva Nair
Hi, On Thu, Feb 4, 2016 at 5:51 AM, ValdikSS wrote: > It's not for DNS resolution (although it should work if "DNS Client" > service is disabled), it's not to break OpenVPN servers on TCP/UDP port 53. I missed that.. Thanks and that does work. So back to the patch, I lost the original email,