Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
as for my observation, people share password with coworkers, they will share cert in the same way :) well, password-only is legitimate setup, so I would add test case for it. maybe bit later. where can I have a look at existing test cases you are talking about? суббота, 2 января 2016 г. пользоват

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Gert Doering
Hi, On Sat, Jan 02, 2016 at 09:14:21PM +0300, ?? wrote: > also, does it make sence to perform unit testing on build like > > setup server with user/password auth on localhost, connect to is using > client, see whether it is ok We do, but we don't run test setups without

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
also, does it make sence to perform unit testing on build like setup server with user/password auth on localhost, connect to is using client, see whether it is ok ? 2015-12-26 12:40 GMT+03:00 Steffan Karger : > On 26-12-15 10:19, Gert Doering wrote: > > On Wed, Dec 23, 2015 at 04:11:17PM +0

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
I'm getting "segmentation fault" after that commit. well, I suspect you beleive that user _always_ has client cert, which is not true. obviously, for preshared keys there''s no user cert, and for user/password auth there's also no user cert (which is our case) is Valgrind I see the following: ht

[Openvpn-devel] [PATCH] Complete push-peer-info documentation and allow IV_PLAT_VER for other platforms than Windows if the client UI supplies it.

2016-01-02 Thread Arne Schwabe
--- doc/openvpn.8 | 6 ++ src/openvpn/ssl.c | 6 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 6d5807f..52ebe59 100644 --- a/doc/openvpn.8 +++ b/doc/openvpn.8 @@ -2962,6 +2962,12 @@ IV_HWADDR= -- the MAC address of clients defau

[Openvpn-devel] [PATCH v5] Implement the compression V2 data format for stub and lz4.

2016-01-02 Thread Arne Schwabe
Patch V2: Fix minor issues found by Steffan Patch V3: split wire codes and compression flags Patch V4: Fix further issues reported by Gert Patch V5: really fix the issues that should be fixed in v2 It has been tested against v3 server and again itself. From James Mail: Compression V2 I have