Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-13 Thread Selva Nair
Hi, On Thu, Dec 10, 2015 at 7:46 PM, Fish wrote: > Based on release/2.3 branch and ValdikSS's v9 patch, this patch is > cross-compiled on Linux and tested on Windows XP/10. The VC project file is > left untouched - you might want to add rpcrt4.lib to compile and link it > under > MSVC. > Builds

Re: [Openvpn-devel] [PATCH applied] Re: Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-12-13 Thread Selva Nair
On Sun, Dec 13, 2015 at 4:00 PM, Gert Doering wrote: > ACK. Lots of people have reviewed this, and it made the patch better :-) > - so I list them all, and take the final blame (ACK) on me... > Thanks (for assuming the blame :). And, ValdikSS, thanks for putting up with all the opinionated com

[Openvpn-devel] [PATCH applied] Re: Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-12-13 Thread Gert Doering
ACK. I verified that this patch is identical to the 2.3 patch except for the option check in options.c, and the #ifdef for VISTA+ - so same ACK here, and same list of reviewers. Thanks. Your patch has been applied to the master branch. commit 38c8565810f892a41a2ea0d18a707676119f1af0 (master) A

[Openvpn-devel] [PATCH applied] Re: Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-12-13 Thread Gert Doering
ACK. Lots of people have reviewed this, and it made the patch better :-) - so I list them all, and take the final blame (ACK) on me... Your patch has been applied to the release/2.3 branch. commit dd628d2e0d786e478fd99d54000dceaa42d53855 (release/2.3) Author: ValdikSS List-Post: openvpn-devel@li

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-13 Thread Gert Doering
Hi, On Fri, Dec 11, 2015 at 10:29:33PM +0200, Lev Stipakov wrote: > Thanks, I think (I think!) I got it now. > > 1) Since we have tt->adapter_index (which temporarily disappeared from > my perception of reality), no need to add new member to tuntap or > tuntap_options. > > 2) tt->adapter_index

[Openvpn-devel] [PATCH applied] Re: Use adapter index for add/delete_route_ipv6

2015-12-13 Thread Gert Doering
ACK, thanks. I have not actually built or tested a 2.3 binary, but since the code is nearly the same as for master and that one works nicely, I assume this works as well. Your patch has been applied to the release/2.3 branch. commit ca8cead8fd8c00154f35b90593442e2bfa8f735d (release/2.3) Author:

Re: [Openvpn-devel] [PATCH applied] Re: Use adapter index for add/delete_route_ipv6

2015-12-13 Thread Gert Doering
Hi, On Sun, Dec 13, 2015 at 08:00:26PM +0100, Gert Doering wrote: > ACK, and thanks. Code looks good and I'm reasonably sure that it will > do the right thing - waiting for buildbot now to produce a windows binary > to actually test it :-) - then applying the 2.3 version to 2.3 Works! "ifconfig

Re: [Openvpn-devel] Options that are "safe" for users to modify?

2015-12-13 Thread Selva Nair
forgot to copy the list.. Hi, Sorry, I missed the point that only referenced files are being replaced. On Sat, Dec 12, 2015 at 9:31 PM, Jonathan K. Bullard wrote: > I'm not clear at all about --crl-verify. Would it ever be used in a > client? Would there be a security risk if a client erased t

[Openvpn-devel] [PATCH applied] Re: Use adapter index for add/delete_route_ipv6

2015-12-13 Thread Gert Doering
ACK, and thanks. Code looks good and I'm reasonably sure that it will do the right thing - waiting for buildbot now to produce a windows binary to actually test it :-) - then applying the 2.3 version to 2.3 Chances are good that this will break compilation with older MSVC versions, though (as the

Re: [Openvpn-devel] Options that are "safe" for users to modify?

2015-12-13 Thread Arne Schwabe
Am 12.12.15 um 23:37 schrieb Jonathan K. Bullard: > Hi. > > On Sat, Dec 12, 2015 at 5:23 PM, Arne Schwabe wrote: >> Might not really be related to this but have looked into the work that >> provides the certificates and keys via the managment console? We have >> even have a contrib program that g

Re: [Openvpn-devel] Options that are "safe" for users to modify?

2015-12-13 Thread Jonathan K. Bullard
Thanks, Selva. On Sat, Dec 12, 2015 at 5:43 PM, Selva Nair wrote: > I suppose, not just adding but also removing options will be allowed. There > could be more options that are ok (i.e not unsafe) to remove but not change. What I'm proposing isn't to allow "add/remove/modify" options in the Open