[Openvpn-devel] Fwd: [PATCH] Use example.com to improve clarity of documentation

2015-11-23 Thread Phillip Smith
Hi all, I sent the below patch last week, but it doesn't seem to have made it to the mail list for some reason, despite being delivered to SourceForge: 18 Nov 2015 12:07:31openvpn-devel@lists.sourceforge.net 216.34.181.68 accepted message./Remote host said: 250 OK id=1ZyrDo-0007pR-Cm/ Cheers

Re: [Openvpn-devel] Topics for today's (Monday, 23rd Nov 2015) community meeting

2015-11-23 Thread Samuli Seppänen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Here's the summary of today's IRC meeting. - --- COMMUNITY MEETING Place: #openvpn-devel on irc.freenode.net List-Post: openvpn-devel@lists.sourceforge.net Date: Monday 23rd Nov 2015 Time: 20:00 CET (19:00 UTC) Planned meeting topics for this

[Openvpn-devel] [PATCH] Fix memory leak in add_option() by simplifying get_ipv6_addr

2015-11-23 Thread Steffan Karger
If get_ipv6_addr() would fail *after* allocating memory for ipv6_local, add_option() would fail to free that memory. The fix here is to remove the allocation from get_ipv6_addr(), and create a separate function for the strip-and-allocate, such that failures are easier to handle. v2 - remove free(

Re: [Openvpn-devel] [PATCH APPLIED] Support for username-only auth file.

2015-11-23 Thread Gert Doering
Hi, On Sat, Nov 14, 2015 at 08:05:45PM +0100, Gert Doering wrote: > On Sun, Oct 11, 2015 at 10:44:20AM +0200, Adriaan de Jong wrote: > > Make OpenVPN read the username from the auth file > > parameter of --auth-user-pass and prompt for a > > password if it's not in the file. > > ACK, applied and

Re: [Openvpn-devel] [PATCH] Fix info.af == AF_UNSPEC case after commit 2bed089d31a12c2d0277e36a64964ebab6640f75

2015-11-23 Thread Gert Doering
Hi, On Mon, Nov 23, 2015 at 11:51:43AM +, Christian Pellegrin wrote: > On Sat, Nov 21, 2015 at 8:06 PM, Gert Doering wrote: > > if (sock->info.af == AF_UNSPEC) > > + { > >msg (M_WARN, "Could not determine IPv4/IPv6 protocol. > > Using %s", > >

Re: [Openvpn-devel] [PATCH] Fix memory leak in add_option() by simplifying get_ipv6_addr

2015-11-23 Thread Gert Doering
Hi, On Mon, Nov 23, 2015 at 07:56:09PM +0100, Steffan Karger wrote: > If get_ipv6_addr() would fail *after* allocating memory for ipv6_local, > add_option() would fail to free that memory. > > The fix here is to remove the allocation from get_ipv6_addr(), and create > a separate function for the

[Openvpn-devel] [PATCH] Fix memory leak in add_option() by simplifying get_ipv6_addr

2015-11-23 Thread Steffan Karger
If get_ipv6_addr() would fail *after* allocating memory for ipv6_local, add_option() would fail to free that memory. The fix here is to remove the allocation from get_ipv6_addr(), and create a separate function for the strip-and-allocate, such that failures are easier to handle. Memory leak found

[Openvpn-devel] [PATCH applied] Re: Client-side part for server restart notification

2015-11-23 Thread Gert Doering
Your patch has been applied to the release/2.3 branch. commit 983f01861c31b3d768ec9b119cd26f8d1f2f7a73 Author: Lev Stipakov List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Nov 23 13:38:13 2015 +0200 Client-side part for server restart notification Signed-off-by: Lev Stipakov

Re: [Openvpn-devel] [PATCH] Client-side part for server restart notification

2015-11-23 Thread Arne Schwabe
Am 23.11.15 um 12:38 schrieb Lev Stipakov: > When client receives "RESTART,N", it advances to the next remote. > > Whole patch (server + client) has been merged to master and will be part of > 2.4. > > ACK, based on same code as in 2.4 and is very small and non intrusive. Arne

Re: [Openvpn-devel] [PATCH] Fix info.af == AF_UNSPEC case after commit 2bed089d31a12c2d0277e36a64964ebab6640f75

2015-11-23 Thread Christian Pellegrin
On Sat, Nov 21, 2015 at 8:06 PM, Gert Doering wrote: > if (sock->info.af == AF_UNSPEC) > + { >msg (M_WARN, "Could not determine IPv4/IPv6 protocol. > Using %s", > addr_family_name(sock->info.lsa->bind_local->ai_family)); > +

[Openvpn-devel] [PATCH applied] Re: polarssl: require >= 1.3.8

2015-11-23 Thread Gert Doering
ACK. Much better than having unresolved symbols at link time :-) Your patch has been applied to the master branch. commit 9d3b7cec5270b2aebf62e80ccaa564aab93fcb37 Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Nov 23 11:26:24 2015 +0100 polarssl: require

[Openvpn-devel] [PATCH] Client-side part for server restart notification

2015-11-23 Thread Lev Stipakov
When client receives "RESTART,N", it advances to the next remote. Whole patch (server + client) has been merged to master and will be part of 2.4. Signed-off-by: Lev Stipakov --- src/openvpn/push.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/openvpn/push.c b/src/openvpn/push.

[Openvpn-devel] [PATCH] polarssl: require >= 1.3.8

2015-11-23 Thread steffan.karger
From: Steffan Karger Since commit 67a67e39, we use API calls that were introduced in polarssl 1.3.8. Update the configure check to reflect that. Signed-off-by: Steffan Karger --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac i

[Openvpn-devel] Topics for today's (Monday, 23rd Nov 2015) community meeting

2015-11-23 Thread Samuli Seppänen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, We're going to have an IRC meeting today starting at 20:00 CET (19:00 UTC) on #openvpn-meeting irc.freenode.net. Note that the meeting channel has changed and that you do _not_ have to be logged in to Freenode to join the channel. Current top