Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-22 Thread Selva Nair
On Sun, Nov 22, 2015 at 12:33 PM, Morris, Russell wrote: > Hi, > > > > Went to get started on this, and I admit – a lot of different and > confusing information about the libraries and include files (and a lot of > it contradicts it seems). Do you have a good source for the “right” files > to gra

[Openvpn-devel] [PATCH applied] Re: Notify clients about server's exit/restart

2015-11-22 Thread Gert Doering
ACK, and thanks for your patience and persistance Since v4 is functionally the same as v3 (just a few #ifdef ENABLE_OCC shuffled around, and different "adjacent" code due to rebasing), I've taken Arne's ACK as valid for v4, too - and add my own for the v3->v4 changes. Your patch has been applied

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-22 Thread Morris, Russell
Hi, Went to get started on this, and I admit – a lot of different and confusing information about the libraries and include files (and a lot of it contradicts it seems). Do you have a good source for the “right” files to grab? Thanks! … Russell From: Selva Nair [mailto:selva.n...@gmail.com]

Re: [Openvpn-devel] [PATCH] Handle ctrl-C and ctrl-break events on Windows

2015-11-22 Thread Selva Nair
Hi, On Sun, Nov 22, 2015 at 11:30 AM, Gert Doering wrote: > On Sun, Nov 22, 2015 at 10:49:13AM -0500, Selva Nair wrote: > >its safer to setup nssm with a delay of 2500 msec > > between ctrl-C and 'kill without prejudice' (aka Terminate). > > Ah, yes. Thanks :-) (you and Samuli need to work on

Re: [Openvpn-devel] [PATCH] Handle ctrl-C and ctrl-break events on Windows

2015-11-22 Thread Gert Doering
Hi, On Sun, Nov 22, 2015 at 10:49:13AM -0500, Selva Nair wrote: > > (Is it actually quicker as well, so does the nssm timeout still need to > > be adjusted? Haven't seen feedback from Samuli here yet) > > > > In my tests openvpn exit processing takes only a few hundred msec, but if > exit-notify

[Openvpn-devel] [PATCH applied] Re: Handle ctrl-C and ctrl-break events on Windows

2015-11-22 Thread Gert Doering
ACK, on the basis that the code looks reasonable, solves a real problem on Win32 and does not affect other platforms. I have *not* tested it Your patch has been applied to the master and release/2.3 branch. commit 87f1be66e88303c51520925f169dc5a8aa58a7f2 (master) commit 29f883fb31b362ffa21f11b67

Re: [Openvpn-devel] [PATCH] Handle ctrl-C and ctrl-break events on Windows

2015-11-22 Thread Selva Nair
Hi, On Sun, Nov 22, 2015 at 10:18 AM, Gert Doering wrote: > Hi, > > On Mon, Nov 16, 2015 at 09:48:09PM -0500, Selva Nair wrote: > > v2 changes > > - cleaner, hopefully easier to get a code review :) > > - handles both console mode and service mode > > -- >8 -- > > > > Handle ctrl-C or ctrl-Bre

[Openvpn-devel] [PATCH applied] Re: polarssl: don't use deprecated functions anymore

2015-11-22 Thread Gert Doering
ACK, based on "it looks reasonable" and "passes all my tests" (and there is a certain matter of trust here that these functions really are what should be used :-) - googling turned up depreciation comments in various polar/embedssl headers for the "easy ones", like md_free_ctx() though) Your patch

Re: [Openvpn-devel] [PATCH] Handle ctrl-C and ctrl-break events on Windows

2015-11-22 Thread Gert Doering
Hi, On Mon, Nov 16, 2015 at 09:48:09PM -0500, Selva Nair wrote: > v2 changes > - cleaner, hopefully easier to get a code review :) > - handles both console mode and service mode > -- >8 -- > > Handle ctrl-C or ctrl-Break sent to the console as a SIGTERM. > Depending on the console mode, windows

Re: [Openvpn-devel] [PATCH] put virtual IPv6 addresses into env

2015-11-22 Thread Gert Doering
Hi, On Fri, Nov 20, 2015 at 06:23:58PM +0100, Heiko Hund wrote: > Add missing environment variables for IPv6 virtual addresses: > > * ifconfig_pool_local_ipv6 > * ifconfig_pool_remote_ipv6 > * ifconfig_pool_ipv6_netbits > > Signed-off-by: Heiko Hund Semi-ACK. I'm not exactly sure, but y

Re: [Openvpn-devel] [PATCH] Fix info.af == AF_UNSPEC case after commit 2bed089d31a12c2d0277e36a64964ebab6640f75

2015-11-22 Thread christian pellegrin
On Sun, Nov 22, 2015 at 1:19 PM, Gert Doering wrote: > Could you test the patch suggestion I sent yesterday? I think your log > *should* (before the ASSERT) show the "Could not determine IPv4/IPv6 > protocol. Using..." message... Ack, will do tomorrow and report. -- Christian Pellegrin, see h

Re: [Openvpn-devel] [PATCH] Fix info.af == AF_UNSPEC case after commit 2bed089d31a12c2d0277e36a64964ebab6640f75

2015-11-22 Thread Gert Doering
Hi, On Sun, Nov 22, 2015 at 01:09:48PM +, christian pellegrin wrote: > Huh, sorry the segfault. Nothing to be sorry about - that code is complicated ("has grown over 10+ years, too many options and platforms") and refactoring it for proper dual-stack support still sees some fallout... > To

Re: [Openvpn-devel] [PATCH] Fix info.af == AF_UNSPEC case after commit 2bed089d31a12c2d0277e36a64964ebab6640f75

2015-11-22 Thread christian pellegrin
Huh, sorry the segfault. To solve this specific problem it's enough to test for AF_UNSPEC in https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/mtu.c#L163, I will prepare the patch tomorrow. I don't think the configuration is too strange. It uses proto udp, mode server and sets local addre