[Openvpn-devel] [PATCH] Remove support for snappy compression.

2015-10-10 Thread Gert Doering
LZ4 is using less CPU at similar performance, and it is easier to build and support for binary installs (as it does not require C++ and a C++ runtime). Since it was never supported in any formally released OpenVPN version, just drop it again. This leaves in the compression opcode for Snappy for d

Re: [Openvpn-devel] [PATCH] Fix trac ticket #569

2015-10-10 Thread Arne Schwabe
Am 10.10.15 um 18:12 schrieb janj...@nikhef.nl: > From: janjust > > Fix trac ticket #569 "White space before end tags can break the config parser" >https://community.openvpn.net/openvpn/ticket/569 > ACK from me. Arne

[Openvpn-devel] [PATCH] Fix trac ticket #569

2015-10-10 Thread janjust
From: janjust Fix trac ticket #569 "White space before end tags can break the config parser" https://community.openvpn.net/openvpn/ticket/569 --- src/openvpn/options.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c i

[Openvpn-devel] [PATCH v3] Send push reply right after async auth complete

2015-10-10 Thread Lev Stipakov
v3: * better comments * better variable naming * include sys/inotify.h if HAVE_SYS_INOTIFY_H is defined v2: More careful inotify_watchers handling * Ensure that same multi_instance is added only once * Ensure that multi_instance is always removed v1: This feature speeds up connection establishmen

Re: [Openvpn-devel] [PATCH: tap-windows6] Added CONTRIBUTING.rst

2015-10-10 Thread Samuli Seppänen
Hi, On Sat, Oct 10, 2015 at 04:36:24PM +0300, sam...@openvpn.net wrote: From: Samuli Seppänen Signed-off-by: Samuli Seppänen Sounds good to me. I'm not sure if I have formal authority for tap-windows6, but anyway "ACK" :-) gert Pushed to tap-windows6. -- Samuli Seppänen Community Ma

Re: [Openvpn-devel] [PATCH: openvpn-build] Added CONTRIBUTING.rst

2015-10-10 Thread Samuli Seppänen
Hi, On Sat, Oct 10, 2015 at 04:38:36PM +0300, sam...@openvpn.net wrote: From: Samuli Seppänen Signed-off-by: Samuli Seppänen --- CONTRIBUTING.rst | 25 + 1 file changed, 25 insertions(+) create mode 100644 CONTRIBUTING.rst Looks good to me. ACK, if I may :) g

[Openvpn-devel] [PATCH applied] Re: Add CONTRIBUTING.rst

2015-10-10 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branch. commit 0c1d92291e4c1829bf503067e1f9d39328d01ee9 (master) commit 6c45f8c9c268910da104b25e242c6465bb0bb54a (release/2.3) Author: Samuli Seppänen List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Oct 10 16:41:14 2015 +0300

Re: [Openvpn-devel] [PATCH: openvpn-build] Added CONTRIBUTING.rst

2015-10-10 Thread Gert Doering
Hi, On Sat, Oct 10, 2015 at 04:38:36PM +0300, sam...@openvpn.net wrote: > From: Samuli Seppänen > > Signed-off-by: Samuli Seppänen > --- > CONTRIBUTING.rst | 25 + > 1 file changed, 25 insertions(+) > create mode 100644 CONTRIBUTING.rst Looks good to me. ACK, if I may

Re: [Openvpn-devel] [PATCH: tap-windows6] Added CONTRIBUTING.rst

2015-10-10 Thread Gert Doering
Hi, On Sat, Oct 10, 2015 at 04:36:24PM +0300, sam...@openvpn.net wrote: > From: Samuli Seppänen > > Signed-off-by: Samuli Seppänen Sounds good to me. I'm not sure if I have formal authority for tap-windows6, but anyway "ACK" :-) gert -- USENET is *not* the non-clickable part of WWW!

[Openvpn-devel] [PATCH: openvpn] Add CONTRIBUTING.rst

2015-10-10 Thread samuli
From: Samuli Seppänen Signed-off-by: Samuli Seppänen --- CONTRIBUTING.rst | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 CONTRIBUTING.rst diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst new file mode 100644 index 000..5004620 --- /dev/null +++ b/

[Openvpn-devel] [PATCH: openvpn-build] Added CONTRIBUTING.rst

2015-10-10 Thread samuli
From: Samuli Seppänen Signed-off-by: Samuli Seppänen --- CONTRIBUTING.rst | 25 + 1 file changed, 25 insertions(+) create mode 100644 CONTRIBUTING.rst diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst new file mode 100644 index 000..70f4d15 --- /dev/null +++ b/CONTR

[Openvpn-devel] [PATCH: tap-windows6] Added CONTRIBUTING.rst

2015-10-10 Thread samuli
From: Samuli Seppänen Signed-off-by: Samuli Seppänen --- CONTRIBUTING.rst | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 CONTRIBUTING.rst diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst new file mode 100644 index 000..6ee5908 --- /dev/null +++ b/CONT

Re: [Openvpn-devel] [PATCH v2] Send push reply right after async auth complete

2015-10-10 Thread David Sommerseth
On 07/10/15 15:32, Lev Stipakov wrote: > v2: > More careful inotify_watchers handling > * Ensure that same multi_instance is added only once > * Ensure that multi_instance is always removed > > v1: > This feature speeds up connection establishment in cases when async > authentication result is not

Re: [Openvpn-devel] ipv6 env vars to client scripts

2015-10-10 Thread Lev Stipakov
Hi Samuel, I like the idea of patch https://community.openvpn.net/openvpn/attachment/ticket/230/patch, I think ifconfig_ipv6_pool_remote_ip is indeed useful - we use it in our production, too. Here: void +setenv_in6_addr_t (struct env_set *es, const char *name_prefix, struct in6_addr *addr

Re: [Openvpn-devel] ipv6 env vars to client scripts

2015-10-10 Thread Lev Stipakov
Hi Samuel, I like the idea of patch https://community.openvpn.net/openvpn/attachment/ticket/230/patch, I think ifconfig_ipv6_pool_remote_ip is indeed useful - we use it in our production, too. Here: void +setenv_in6_addr_t (struct env_set *es, const char *name_prefix, struct in6_addr *addr

Re: [Openvpn-devel] ipv6 env vars to client scripts

2015-10-10 Thread Lev Stipakov
Hi Samuel, I like the idea of patch https://community.openvpn.net/openvpn/attachment/ticket/230/patch, I think ifconfig_ipv6_pool_remote_ip is indeed useful - we use it in our production, too. Here: void +setenv_in6_addr_t (struct env_set *es, const char *name_prefix, struct in6_addr *addr, cons

Re: [Openvpn-devel] ipv6 env vars to client scripts

2015-10-10 Thread Lev Stipakov
Hi Samuel, I like the idea of patch https://community.openvpn.net/openvpn/attachment/ticket/230/patch, I think ifconfig_ipv6_pool_remote_ip is indeed useful - we use it in our production, too. Here: void +setenv_in6_addr_t (struct env_set *es, const char *name_prefix, struct in6_addr *addr

Re: [Openvpn-devel] [PATCH] Update expiry date in management event loop

2015-10-10 Thread Gert Doering
Hi, On Sat, Oct 10, 2015 at 10:39:08AM +0200, Arne Schwabe wrote: > Am 22.01.14 um 09:27 schrieb Thomas Veerman: > > When there are events from the management console with an interval shorter > > than 1 second, the event loop never stops as it keeps resetting event_wait. > > ACK. It is a strange

[Openvpn-devel] [PATCH applied] Re: Fix compilcation error with --disable-crypto

2015-10-10 Thread Gert Doering
Your patch has been applied to the master branch. (I've taken the liberty to fix the typo in the commit message :) ) commit b05a453be5dd21326e79f42b0a363f2f23eaa29a Author: Lev Stipakov List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Oct 10 13:14:29 2015 +0300 Fix compilation err

Re: [Openvpn-devel] [PATCH] Fix compilcation error with --disable-crypto

2015-10-10 Thread Arne Schwabe
Am 10.10.15 um 12:14 schrieb Lev Stipakov: > Also disable behavior for static key setup. ACK from. Arne

[Openvpn-devel] [PATCH] Fix compilcation error with --disable-crypto

2015-10-10 Thread Lev Stipakov
Also disable behavior for static key setup. --- src/openvpn/forward.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c index 513fbae..c17be35 100644 --- a/src/openvpn/forward.c +++ b/src/openvpn/forward.c @@ -1199,13 +1199,16

[Openvpn-devel] [PATCH applied] Re: Fix --mtu-disc option with IPv6 transport

2015-10-10 Thread Gert Doering
ACK (to v2). Your patch has been applied to the master branch. commit 2bed089d31a12c2d0277e36a64964ebab6640f75 Author: Julien Muchembled List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Oct 10 11:44:51 2015 +0200 Fix --mtu-disc option with IPv6 transport Signed-off-by: Julien

[Openvpn-devel] [[Patch V2]] Fix --mtu-disc option with IPv6 transport

2015-10-10 Thread Arne Schwabe
From: Julien Muchembled Socket configuration of MTU discovery was done unconditionally at IP level, which has no effect for other protocols. This fixes the issue of OpenVPN sending fragmented tcp6/udp6 packets even when 'mtu-disc yes' option is passed. Patch V2 (by Arne Schwabe): Rebase to curre

Re: [Openvpn-devel] [PATCH applied] Re: Fast recovery when host is in unreachable network

2015-10-10 Thread Gert Doering
Hi, On Sat, Oct 10, 2015 at 11:10:10AM +0200, Gert Doering wrote: > Your patch has been applied to the master branch. And *blam* it explodes if --disable-crypto is used... gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include +-I../../src/compat -g -O2 -MT forward.o -MD -M

[Openvpn-devel] [PATCH applied] Re: Fast recovery when host is in unreachable network

2015-10-10 Thread Gert Doering
Your patch has been applied to the master branch. commit 99daa6b19270775006f034f21936c98a9005477d Author: Lev Stipakov List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Mar 2 19:58:31 2015 +0200 Fast recovery when host is in unreachable network Acked-by: Arne Schwabe Mes

Re: [Openvpn-devel] [PATCH] Update expiry date in management event loop

2015-10-10 Thread Arne Schwabe
Am 22.01.14 um 09:27 schrieb Thomas Veerman: > When there are events from the management console with an interval shorter > than 1 second, the event loop never stops as it keeps resetting event_wait. > ACK. It is a strange cornercase and the patch does not change behaviour otherwise. Arne