Re: [Openvpn-devel] [PATCH] plugins, down-root: Code style clean-up

2014-12-08 Thread Steffan Karger
ACK -Steffan On 08-12-14 23:45, David Sommerseth wrote: > From: David Sommerseth > > The coding style was somewhat chaotic. Cleaning it up using the astyle > tool. The style parameters are coherent to what was agreed upon at the > Munich Hackathon 2014 [1]. > > astyle --style=allman --i

[Openvpn-devel] [PATCH] plugins, down-root: Code style clean-up

2014-12-08 Thread David Sommerseth
From: David Sommerseth The coding style was somewhat chaotic. Cleaning it up using the astyle tool. The style parameters are coherent to what was agreed upon at the Munich Hackathon 2014 [1]. astyle --style=allman --indent=spaces=4 -c Also included a "Local variables" section which some

Re: [Openvpn-devel] [PATCH applied] plugin, down-root: Fix compiler warnings

2014-12-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/14 22:40, David Sommerseth wrote: > From: David Sommerseth > > > Your patch has been applied to the master branch. > > commit 7dd51f6f50b17ab91cbb724e2d5e96657fab834a Author: David > Sommerseth Date: Mon Dec 8 22:31:15 2014 +0100 > > p

Re: [Openvpn-devel] [PATCH applied] plugin, down-root: Fix compiler warnings

2014-12-08 Thread David Sommerseth
From: David Sommerseth -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 7dd51f6f50b17ab91cbb724e2d5e96657fab834a Author: David Sommerseth List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Dec 8 22:31:15 2014 +0100 plugin, dow

Re: [Openvpn-devel] [PATCH] plugin, down-root: Fix compiler warnings

2014-12-08 Thread Steffan Karger
ACK -Steffan On 08-12-14 22:35, David Sommerseth wrote: > From: David Sommerseth > > Removed a few compiler warnings: > down-root.c:164:4: warning: implicit declaration of function 'warn' > [-Wimplicit-function-declaration] > down-root.c:239:5: warning: implicit declaration of function 'er

[Openvpn-devel] [PATCH] plugin, down-root: Fix compiler warnings

2014-12-08 Thread David Sommerseth
From: David Sommerseth Removed a few compiler warnings: down-root.c:164:4: warning: implicit declaration of function 'warn' [-Wimplicit-function-declaration] down-root.c:239:5: warning: implicit declaration of function 'err' [-Wimplicit-function-declaration] down-root.c:461:7: warning: un

Re: [Openvpn-devel] [PATCH applied] Prevent memory drain for long lasting floating sessions

2014-12-08 Thread David Sommerseth
From: David Sommerseth -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 09cf2ec5c09d35c72f2af0d988de8152378a182a Author: Lev Stipakov List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Dec 8 18:48:45 2014 +0200 Prevent memory

Re: [Openvpn-devel] [PATCH applied] Add the peer-id to the output of the status command

2014-12-08 Thread David Sommerseth
From: David Sommerseth -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 1b9541922ad6ff6ee46c84f43cd23b7064f7919d Author: Lev Stipakov List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Dec 8 19:06:02 2014 +0200 Add the peer-id

Re: [Openvpn-devel] [PATCH] Prevent memory drain for long lasting floating sessions

2014-12-08 Thread Steffan Karger
ACK. Less memory usage (even without float), and got rid of a dynamic allocation, nice! Code looks good and passes my local tests. -Steffan On 08-12-14 17:48, Lev Stipakov wrote: > For every float event we generate prefix, which allocates 256 + 64 > bytes. That memory is reclaimed when client dis

Re: [Openvpn-devel] [PATCH] Add the peer-id to the output of the status command

2014-12-08 Thread Arne Schwabe
Am 08.12.14 18:06, schrieb Lev Stipakov: > This adds peer-id to the status output which might help analyze floating > logs. This will change the output of status in the same way commit > 662ce6acc065bddf6490b3494725b8b3987b7def did. > > ACK. Arne

[Openvpn-devel] [PATCH] Add the peer-id to the output of the status command

2014-12-08 Thread Lev Stipakov
This adds peer-id to the status output which might help analyze floating logs. This will change the output of status in the same way commit 662ce6acc065bddf6490b3494725b8b3987b7def did. Signed-off-by: Lev Stipakov --- src/openvpn/multi.c | 14 -- 1 file changed, 8 insertions(+), 6 de

[Openvpn-devel] [PATCH] Prevent memory drain for long lasting floating sessions

2014-12-08 Thread Lev Stipakov
For every float event we generate prefix, which allocates 256 + 64 bytes. That memory is reclaimed when client disconnects, so long lasting and constantly floating sessions drain memory. As a fix use preallocated buffer inside multi_instance for storing multi_prefix. Signed-off-by: Lev Stipakov

[Openvpn-devel] [PATCH] Add Mac OS X keychain support

2014-12-08 Thread Vasily Kulikov
This patch adds support for using certificates stored in the Mac OSX Keychain to authenticate with the OpenVPN server. This works with certificates stored on the computer as well as certificates on hardware tokens that support Apple's tokend interface. The patch is very similar to, and also based