Re: [Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-27 Thread Gert Doering
Hi, On Thu, Nov 27, 2014 at 05:08:09PM +0200, Lev Stipakov wrote: > As for the second question - hard to say. If we make it opt-in, we > probably will need to announce this feature loudly to make users aware > of that. From the other side, it is not inconceivable to assume that > someone might not

Re: [Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-27 Thread Lev Stipakov
Hello, Currently it should be safe, since multi_create_instance returns NULL if amount of clients >= max_clients. In this case we won't reach that "for" loop thanks to "if (mi)" check. But it probably won't harm to assert if we've reached "for" loop and could not find available "instance" item. I

Re: [Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-27 Thread Gert Doering
Hi, On Sun, Nov 23, 2014 at 05:17:11PM +0200, Lev Stipakov wrote: > Changes in v7: > A few nitpicks. Went in, and has just been pushed. Time for your dance now :-) Question to you: > @@ -75,6 +101,16 @@ multi_get_create_instance_udp (struct multi_context *m) > { >

[Openvpn-devel] [PATCH applied] Re: Add client-only support for peer-id.

2014-11-27 Thread Gert Doering
Your patch has been applied to the release/2.3 branch. commit 0e1fd33247460bdfa65d306e8bcdd3cbafed8b73 Author: Gert Doering List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Nov 23 20:17:30 2014 +0100 Add client-only support for peer-id. Signed-off-by: Gert Doering Acked

[Openvpn-devel] [PATCH applied] Re: Peer-id patch v7

2014-11-27 Thread Gert Doering
ACK from me as well. Your patch has been applied to the master branch (and a client-only version of this has been applied to release/2.3 - separate mail coming). commit 65eedc353349d2967fc03c54da807727e416e1b0 (master) Author: Lev Stipakov List-Post: openvpn-devel@lists.sourceforge.net Date: S