Re: [Openvpn-devel] [PATCH] socket: remove duplicate expression

2014-11-22 Thread Arne Schwabe
Am 22.11.14 21:13, schrieb Yegor Yefremov: > Found via cppcheck and compile-tested. > > Signed-off-by: Yegor Yefremov > --- > src/openvpn/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c > index 29f9958..331a9d9 100644 >

[Openvpn-devel] [PATCH] socket: remove duplicate expression

2014-11-22 Thread Yegor Yefremov
Found via cppcheck and compile-tested. Signed-off-by: Yegor Yefremov --- src/openvpn/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index 29f9958..331a9d9 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -26

[Openvpn-devel] [PATCH] Add client-only support for peer-id.

2014-11-22 Thread Gert Doering
This is a reduced version of the peer-id patch from Lev Stipakov implementing only the client side bits - send IV_PROTO=2, accept "peer-id " as pushed option, support P_DATA_V2 packets. Signed-off-by: Gert Doering --- src/openvpn/init.c | 12 +++- src/openvpn/options.c| 6

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Gert Doering
Hiya, On Sat, Nov 22, 2014 at 11:47:05AM +0100, Arne Schwabe wrote: > Almost anybody always turns this feature on, at least all distribution > have it on. Which is indeed a strong argument for removing the conditional... maybe quickly discuss this ("anyone strongly opposed?") at the next meeting?

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Arne Schwabe
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22.11.2014 11:21, Gert Doering wrote: > Hi, > > On Sat, Nov 22, 2014 at 10:43:00AM +0100, Steffan Karger wrote: >> On 21-11-14 20:43, Yegor Yefremov wrote: >>> This patch is a result of our IRC discussion with Arne. Alternative >>> approach were to

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Arne Schwabe
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22.11.2014 11:21, Gert Doering wrote: Almost anybody always turns this feature on, at least all distribution have it on. Arne -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (MingW32) iEYEARECAAYFAlRwaacACgkQe8+cMNS4zReyrwCgq1gUP6AYs99pGV3M

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Gert Doering
Hi, On Sat, Nov 22, 2014 at 10:43:00AM +0100, Steffan Karger wrote: > On 21-11-14 20:43, Yegor Yefremov wrote: > > This patch is a result of our IRC discussion with Arne. Alternative > > approach were to always build with password-save functionality without > > configure option at all. > > Thanks

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Steffan Karger
Hi Yegor, On 21-11-14 20:43, Yegor Yefremov wrote: > This patch is a result of our IRC discussion with Arne. Alternative > approach were to always build with password-save functionality without > configure option at all. Thanks for the patch. But this explanation doesn't help me much in understan