Re: [Openvpn-devel] [PATCH v2 2/2] Clean up the pipe closing in openvpn_popen()

2014-09-09 Thread Gert Doering
Hi, On Tue, Sep 09, 2014 at 07:26:13PM +0200, David Sommerseth wrote: > From: David Sommerseth > > Do the proper closing of the pipe ends which is not being used, > also in error situations. Moved the closing of the parent side > before the waitpid(), to be consistent with the child side (as >

Re: [Openvpn-devel] [PATCH v2 1/2] Don't try to use systemd-ask-password if it is not available

2014-09-09 Thread Gert Doering
HI, On Tue, Sep 09, 2014 at 07:26:12PM +0200, David Sommerseth wrote: > From: David Sommerseth > > If the SYSTEMD_ASK_PASSWORD_PATH executable cannot be found, we > don't consider systemd as running. > > [v2 - Don't clean up white-space] ACK, useful functionality, code looks good. Not tested,

[Openvpn-devel] [PATCH v2 1/2] Don't try to use systemd-ask-password if it is not available

2014-09-09 Thread David Sommerseth
From: David Sommerseth If the SYSTEMD_ASK_PASSWORD_PATH executable cannot be found, we don't consider systemd as running. [v2 - Don't clean up white-space] Signed-off-by: David Sommerseth --- src/openvpn/console.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src

[Openvpn-devel] [PATCH v2 0/2] Further systemd cleanups

2014-09-09 Thread David Sommerseth
From: David Sommerseth This replaces patch 2/4 [1] and patch 3/4 [2] of the last round, just fixing up things from the review. Patch 1/4 [3] got an ACK and have been applied, while patch 4/4 [4] will be considered in a bigger scope. [1]

[Openvpn-devel] [PATCH v2 2/2] Clean up the pipe closing in openvpn_popen()

2014-09-09 Thread David Sommerseth
From: David Sommerseth Do the proper closing of the pipe ends which is not being used, also in error situations. Moved the closing of the parent side before the waitpid(), to be consistent with the child side (as early as possible). Also improved the error messages with more details. [v2 - Don

Re: [Openvpn-devel] [PATCH applied] Don't let openvpn_popen() keep zombies around

2014-09-09 Thread davids
From: David Sommerseth -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit d886d468849051af525bb8ff1b9080f6c934e3ab Author: David Sommerseth List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Sep 5 14:26:32 2014 +0200 Don't let o