From: David Sommerseth
Do the proper closing of the pipe ends which is not being used,
also in error situations. Moved the closing of the parent side
before the waitpid(), to be consistent with the child side (as
early as possible).
Also improved the error messages with more details.
Signed-of
From: David Sommerseth
If the SYSTEMD_ASK_PASSWORD_PATH executable cannot be found, we
don't consider systemd as running.
Also cleaned up some white-space issues here while at it.
Signed-off-by: David Sommerseth
---
src/openvpn/console.c | 11 ++-
1 file changed, 6 insertions(+), 5 de
From: David Sommerseth
Commit 9449e6a9eba30c9ed054f57d630a88c9f087080f introduced the
openvpn_popen() function to support retrieving passwords via systemd.
It was discovered that the child processes openvpn fork()ed would
be lingering around until openvpn stopped. This was due to the lack
of a
From: David Sommerseth
The whole coding style was a mishmash of tab/spaces and different
alignments.
Reformatted to 2 space indents (no tabs).
Signed-off-by: David Sommerseth
---
src/openvpn/misc.c | 81 +++---
1 file changed, 41 insertions(+),
From: David Sommerseth
There were a few issues with the systemd implementation,
where the openvpn binary would have zombie processes attached
to itself when systemd-ask-password was used. In addition
to not always properly closing the communcation pipes used.
This patch set also avoids OpenVPN
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/07/14 22:24, Mike Gilbert wrote:
> Gentoo Linux installs this in /usr/bin by default. Also, the user
> may have installed it in /usr/local/bin if building from source.
ACK. Also considering that Fedora have moved /{bin,sbin} to
/usr/{bin,sbin},
From: David Sommerseth
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Your patch has been applied to the master branch.
commit ba79c71d1255651bfcb8570519b4033c763d47d3
Author: Mike Gilbert
List-Post: openvpn-devel@lists.sourceforge.net
Date: Thu Jul 3 16:24:05 2014 -0400
Add configure c
