[Openvpn-devel] [PATCH applied] Re: Remove ENABLE_BUFFER_LIST

2014-07-09 Thread Gert Doering
ACK. Straightforward, and not really "optional" code in any way. Your patch has been applied to the master branch. commit 0c21b2dba9fca5f3e7effc45a495be1f5a9d0246 Author: Arne Schwabe List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Jul 7 14:12:22 2014 +0200 Remove ENABLE_BUFFER_

Re: [Openvpn-devel] [Patch v3] Remove #ifdefs for client nat support.

2014-07-09 Thread Gert Doering
Hi, On Tue, Jul 08, 2014 at 11:21:41AM +0200, Arne Schwabe wrote: > --- a/src/openvpn/forward.c > +++ b/src/openvpn/forward.c > @@ -1018,6 +1018,8 @@ process_ip_header (struct context *c, unsigned int > flags, struct buffer *buf) >if (!c->options.passtos) > flags &= ~PIPV4_PASSTOS; > #e

Re: [Openvpn-devel] [PATCH] Do not upcase x509-username-field for mixed-case arguments.

2014-07-09 Thread Steffan Karger
Hi, On 08-07-14 10:16, Kalnozols, Andris wrote: > Thanks, Steffan, for the comments and code cleanup. Your method > is definitely safer and has less clutter. I tested your version > and it works as intended. Great, let's get the patch into git then. > Regarding the "ext:" argument prefix, I ha

Re: [Openvpn-devel] session-id implementation

2014-07-09 Thread Arne Schwabe
Am 29.06.14 18:13, schrieb Arne Schwabe: > Am 27.03.14 09:57, schrieb Lev Stipakov: >> Hi, >> >> Same patch with added NULL check in push.c:308. Turns out that >> peer_info might be NULL. >> > I looked at the patched, a few minor nitpicks: > > - The test should be if the IV_PROTO is at least 2 and