ACK. Straightforward, and not really "optional" code in any way.
Your patch has been applied to the master branch.
commit 0c21b2dba9fca5f3e7effc45a495be1f5a9d0246
Author: Arne Schwabe
List-Post: openvpn-devel@lists.sourceforge.net
Date: Mon Jul 7 14:12:22 2014 +0200
Remove ENABLE_BUFFER_
Hi,
On Tue, Jul 08, 2014 at 11:21:41AM +0200, Arne Schwabe wrote:
> --- a/src/openvpn/forward.c
> +++ b/src/openvpn/forward.c
> @@ -1018,6 +1018,8 @@ process_ip_header (struct context *c, unsigned int
> flags, struct buffer *buf)
>if (!c->options.passtos)
> flags &= ~PIPV4_PASSTOS;
> #e
Hi,
On 08-07-14 10:16, Kalnozols, Andris wrote:
> Thanks, Steffan, for the comments and code cleanup. Your method
> is definitely safer and has less clutter. I tested your version
> and it works as intended.
Great, let's get the patch into git then.
> Regarding the "ext:" argument prefix, I ha
Am 29.06.14 18:13, schrieb Arne Schwabe:
> Am 27.03.14 09:57, schrieb Lev Stipakov:
>> Hi,
>>
>> Same patch with added NULL check in push.c:308. Turns out that
>> peer_info might be NULL.
>>
> I looked at the patched, a few minor nitpicks:
>
> - The test should be if the IV_PROTO is at least 2 and