[Openvpn-devel] [PATCH 2/2] Remove unneeded wrapper functions in crypto_openssl.c

2014-05-25 Thread Steffan Karger
Both EVPCipherInit_ov() and EVPCipherUpdate_ov() wrapped OpenSSL functions without any changes, so lets just use the functions directly. Signed-off-by: Steffan Karger --- src/openvpn/crypto_openssl.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/op

[Openvpn-devel] [PATCH 1/2] Remove function without effect (cipher_ok() always returned true).

2014-05-25 Thread Steffan Karger
Signed-off-by: Steffan Karger --- src/openvpn/crypto_openssl.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index 1501bc8..6671a42 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_opens

[Openvpn-devel] [PATCH] Some crypto_openssl.c cleanup for release/2.3

2014-05-25 Thread Steffan Karger
Hi, These are 1/3 and 2/3 of the crypto_openssl.c cleanup patches, but rebased and fixed for the release/2.3 branch. -Steffan

[Openvpn-devel] [PATCH applied] Re: Use SSL_MODE_RELEASE_BUFFERS if available

2014-05-25 Thread Gert Doering
Hi, your patch has been applied to the OpenVPN master branch. Sorry it took us so long... commit a6c573d22566a1dfc44ab060687192a4debc2e03 Author: Cristian Rodriguez List-Post: openvpn-devel@lists.sourceforge.net Date: Sun May 25 15:52:58 2014 +0200 Use SSL_MODE_RELEASE_BUFFERS if availab

[Openvpn-devel] [PATCH 3/3] Remove unneeded defines (were needed for pre-0.9.7 OpenSSL).

2014-05-25 Thread Steffan Karger
Since we now require OpenSSL 0.9.8, we don't need these anymore. Signed-off-by: Steffan Karger --- src/openvpn/crypto_openssl.c | 8 1 file changed, 8 deletions(-) diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index 22bb7c9..c3480e0 100644 --- a/src/openvpn/c

[Openvpn-devel] [PATCH 2/3] Remove unneeded wrapper functions in crypto_openssl.c

2014-05-25 Thread Steffan Karger
Both EVPCipherInit_ov() and EVPCipherUpdate_ov() wrapped OpenSSL functions without any changes, so lets just use the functions directly. Signed-off-by: Steffan Karger --- src/openvpn/crypto_openssl.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/op

[Openvpn-devel] [PATCH 1/3] Remove function without effect (cipher_ok() always returned true).

2014-05-25 Thread Steffan Karger
Signed-off-by: Steffan Karger --- src/openvpn/crypto_openssl.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index 6199e61..f471eee 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_opens

[Openvpn-devel] [PATCH] Some crypto_openssl.c cleanup

2014-05-25 Thread Steffan Karger
Hi, The following three patches clean up minor stuff I came along while working in crypto_openssl.c. No functional changes. 1/3 and 2/3 can be applied to master as well as release/2.3, to keep the code differences between 2.3 and 2.4 smaller. I'll send rebased patches for these later on. 3/3 req

[Openvpn-devel] [PATCH] Use SSL_MODE_RELEASE_BUFFERS if available

2014-05-25 Thread Steffan Karger
Hi, Attached a very old patch from trac, rebased onto master and incorporated info from the trac ticket into the commit msg. See: https://community.openvpn.net/openvpn/ticket/157 The change looks sane, and it passes client and loopback tests, so ACK. -Steffan >From ffe73c0466e6f52ab7d9c49e5b6b7e