Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Tore Anderson
* Arne Schwabe > Can you try the following one line patch? I will do a better cleanup > patch later but this should fix the problem Yep, this works. Thanks! FWIW: Now I also got to test git master with what I wanted to in the first place, namely to see whether or not all the nice dualstack chang

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Arne Schwabe
Am 10.01.14 15:03, schrieb Tore Anderson: > * Arne Schwabe > >> That is very weird. I would expect it to fail for both cases in the same >> way. The codepath should trigger the same ASSERT(0) in both cases (or >> work in both). Can you forward a copy of your server configuration to >> me? Then I wi

Re: [Openvpn-devel] [PATCH 1/2] remove some "unused variable" warnings

2014-01-10 Thread David Sommerseth
On 10/01/14 17:25, Gert Doering wrote: > Signed-off-by: Gert Doering > --- > src/openvpn/comp-lz4.c | 1 - > src/openvpn/options.c | 2 ++ > src/openvpn/ssl.c | 3 +-- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/openvpn/comp-lz4.c b/src/openvpn/comp-lz4.c > inde

Re: [Openvpn-devel] [PATCH 2/2] Cleanup ir6->netbits handling.

2014-01-10 Thread Arne Schwabe
Am 10.01.14 17:25, schrieb Gert Doering: > Get rid of all "if (ir6->netbits>=0)" checks, as those are always true > (unlike ir->netbits for IPv4, we don't do the special case for "if it's > a host, put -1 in there" for IPv6). > > Merge mroute_helper_{add,del}_iroute and mroute_helper_{add,del}_irou

Re: [Openvpn-devel] [PATCH 1/2] remove some "unused variable" warnings

2014-01-10 Thread Arne Schwabe
Am 10.01.14 17:25, schrieb Gert Doering: > Signed-off-by: Gert Doering > --- > src/openvpn/comp-lz4.c | 1 - > src/openvpn/options.c | 2 ++ > src/openvpn/ssl.c | 3 +-- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/openvpn/comp-lz4.c b/src/openvpn/comp-lz4.c > ind

Re: [Openvpn-devel] [PATCH] Document issue with --chroot, /dev/urandom and PolarSSL.

2014-01-10 Thread David Sommerseth
On 10/01/14 22:30, Gert Doering wrote: > See trac#218 > > Signed-off-by: Gert Doering > --- > doc/openvpn.8 | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/openvpn.8 b/doc/openvpn.8 > index 7736c63..94fd00e 100644 > --- a/doc/openvpn.8 > +++ b/doc/openvpn.8 > @@ -2097,6 +209

[Openvpn-devel] [PATCH] Document issue with --chroot, /dev/urandom and PolarSSL.

2014-01-10 Thread Gert Doering
See trac#218 Signed-off-by: Gert Doering --- doc/openvpn.8 | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 7736c63..94fd00e 100644 --- a/doc/openvpn.8 +++ b/doc/openvpn.8 @@ -2097,6 +2097,13 @@ In many cases, the parameter can point to an empty dir

[Openvpn-devel] [PATCH 2/2] Cleanup ir6->netbits handling.

2014-01-10 Thread Gert Doering
Get rid of all "if (ir6->netbits>=0)" checks, as those are always true (unlike ir->netbits for IPv4, we don't do the special case for "if it's a host, put -1 in there" for IPv6). Merge mroute_helper_{add,del}_iroute and mroute_helper_{add,del}_iroute6 into unified mroute_helper_{add,del}_iroute46(

[Openvpn-devel] [PATCH 1/2] remove some "unused variable" warnings

2014-01-10 Thread Gert Doering
Signed-off-by: Gert Doering --- src/openvpn/comp-lz4.c | 1 - src/openvpn/options.c | 2 ++ src/openvpn/ssl.c | 3 +-- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/openvpn/comp-lz4.c b/src/openvpn/comp-lz4.c index afa43b1..4651148 100644 --- a/src/openvpn/comp-lz4.c ++

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Gert Doering
Hi, On Fri, Jan 10, 2014 at 03:30:10PM +0100, Arne Schwabe wrote: > But > > [AF_INET6]:::87.238.42.150:47707 > > and > > [AF_INET6]2a02:c0:100:0:9e8e:99ff:fed1:5243:56277 > > should be same the same size and handled both the same way from OpenVPN since > they are both IPv6. Good point.

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Arne Schwabe
Am 10.01.14 15:07, schrieb Gert Doering: > Hi, > > On Fri, Jan 10, 2014 at 02:51:48PM +0100, Arne Schwabe wrote: >> That is very weird. I would expect it to fail for both cases in the same >> way. The codepath should trigger the same ASSERT(0) in both cases (or >> work in both). > ... unless somet

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Gert Doering
Hi, On Fri, Jan 10, 2014 at 02:51:48PM +0100, Arne Schwabe wrote: > That is very weird. I would expect it to fail for both cases in the same > way. The codepath should trigger the same ASSERT(0) in both cases (or > work in both). ... unless something is overwriting to->ai_family, for example by

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Tore Anderson
* Arne Schwabe > That is very weird. I would expect it to fail for both cases in the same > way. The codepath should trigger the same ASSERT(0) in both cases (or > work in both). Can you forward a copy of your server configuration to > me? Then I will try to reproduce that problem. Sure thing, he

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Tore Anderson
* Gert Doering > Just to be sure I understand: it works for "proto udp6" if you do *not* > use --multihome on the server? Correct. Apologies for being unclear. Tore

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Arne Schwabe
Am 10.01.14 14:32, schrieb Tore Anderson: > If I connect to an openvpn server using "proto udp6" and "multihome", it > instantly crashes with an assertion failure: > > Jan 10 14:25:58 greed ovpn-server[9905]: 2a02:c0:100:0:9e8e:99ff:fed1:5243 > TLS: Initial packet from [AF_INET6]2a02:c0:100:0:9e8e

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Gert Doering
Hi, On Fri, Jan 10, 2014 at 02:32:23PM +0100, Tore Anderson wrote: > If I connect to an openvpn server using "proto udp6" and "multihome", it > instantly crashes with an assertion failure: Just to be sure I understand: it works for "proto udp6" if you do *not* use --multihome on the server? > Th

[Openvpn-devel] git master proto udp6+multihome is broken

2014-01-10 Thread Tore Anderson
If I connect to an openvpn server using "proto udp6" and "multihome", it instantly crashes with an assertion failure: Jan 10 14:25:58 greed ovpn-server[9905]: 2a02:c0:100:0:9e8e:99ff:fed1:5243 TLS: Initial packet from [AF_INET6]2a02:c0:100:0:9e8e:99ff:fed1:5243:56277 (via 2a02:c0:1001:100::145%e

Re: [Openvpn-devel] [PATCH 10/10] Implement dual stack client support for OpenVPN

2014-01-10 Thread Gert Doering
Hi, On Fri, Jan 10, 2014 at 08:35:33AM +0100, Tore Anderson wrote: > https://git.gnome.org/browse/network-manager-openvpn/commit/?id=77115c5377e009220c3c98102450f92d3a7f6f9e > > This will likely go into Fedora 20. Woot! This is great news indeed :-) gert -- USENET is *not* the non-clickable p

Re: [Openvpn-devel] [PATCH 10/10] Implement dual stack client support for OpenVPN

2014-01-10 Thread Tore Anderson
* Tore Anderson >>> FWIW, I'd like to push the GNOME NetworkManager folks some more >>> to implement IPv6 support in their OpenVPN plugin, which is >>> currently IPv4 only. This patch breaks one of the assumptions >>> made there, in particular that IPv4 transport will always be used >>> when OpenV